[AMD] Disable LLVM vector combine pass#9260
Merged
Merged
Conversation
antiagainst
force-pushed
the
amd-vector-combine
branch
from
e294b57 to
fe0e8c4
Compare
antiagainst
force-pushed
the
amd-vector-combine
branch
2 times, most recently
from
9b81876 to
0109f08
Compare
antiagainst
force-pushed
the
amd-vector-combine
branch
from
0109f08 to
84bf34b
Compare
antiagainst
force-pushed
the
amd-vector-combine
branch
from
84bf34b to
c67b24a
Compare
Collaborator
|
if it is just for debugging, would using the existing |
Member
Author
|
We tested internally on cases it's not causing regressions. So I do want to disable it permantly. The introduced knob is more for debugging just in case some bad cases surface up after this. I can also remove it. |
Collaborator
and doing |
antiagainst
changed the title
Member
Author
|
Yeah that works for debugging. I think the new option was confusing so I dropped it. |
ThomasRaoux
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pass is causing more difficulties than help
for us.