Skip to content

Prevent cache base64 dir names from starting with a hyphen #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterbell10 merged 7 commits into from
Nov 11, 2024
Merged

Prevent cache base64 dir names from starting with a hyphen #5088

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7f11f2
Prepend an underscore to the filename if it starts with a '-'
fulvius31 Nov 6, 2024
c9db0c1
Fix from yapf
fulvius31 Nov 6, 2024
79796bc
Merge branch 'main' into base64_cache_dir_unix
fulvius31 Nov 6, 2024
9faae9e
Merge branch 'main' into base64_cache_dir_unix
fulvius31 Nov 10, 2024
d28f85a
Use base32 instead of base64
fulvius31 Nov 10, 2024
691b0ff
Use base32 instead of base64
fulvius31 Nov 10, 2024
393fcab
Merge branch 'main' into base64_cache_dir_unix
fulvius31 Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions python/triton/runtime/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,9 @@ def put_group(self, filename: str, group: Dict[str, str]):
__cache_cls_nme = "DEFAULT"


def _base64(key):
def _base32(key):
# Assume key is a hex string.
return base64.urlsafe_b64encode(bytes.fromhex(key)).decode("utf-8").rstrip("=")
return base64.b32encode(bytes.fromhex(key)).decode("utf-8").rstrip("=")


def get_cache_manager(key) -> CacheManager:
Expand All @@ -274,15 +274,15 @@ def get_cache_manager(key) -> CacheManager:
__cache_cls = getattr(module, clz_nme)
__cache_cls_nme = user_cache_manager

return __cache_cls(_base64(key))
return __cache_cls(_base32(key))


def get_override_manager(key) -> CacheManager:
return __cache_cls(_base64(key), override=True)
return __cache_cls(_base32(key), override=True)


def get_dump_manager(key) -> CacheManager:
return __cache_cls(_base64(key), dump=True)
return __cache_cls(_base32(key), dump=True)


def make_so_cache_key(version_hash, signature, constants, ids, **kwargs):
Expand All @@ -292,4 +292,4 @@ def make_so_cache_key(version_hash, signature, constants, ids, **kwargs):
for kw in kwargs:
key = f"{key}-{kwargs.get(kw)}"
key = hashlib.sha256(key.encode("utf-8")).hexdigest()
return _base64(key)
return _base32(key)