Prevent cache base64 dir names from starting with a hyphen#5088
Merged
peterbell10 merged 7 commits intotriton-lang:mainfrom Nov 11, 2024
Merged
Prevent cache base64 dir names from starting with a hyphen#5088peterbell10 merged 7 commits intotriton-lang:mainfrom
peterbell10 merged 7 commits intotriton-lang:mainfrom
Conversation
to prevent issues with command-line operations on Unix-like systems.
minjang
approved these changes
Nov 9, 2024
Contributor
minjang
left a comment
minjang
left a comment
There was a problem hiding this comment.
Thanks for addressing this issue! LGTM. Let an OpenAI folk merge this PR.
ThomasRaoux
reviewed
Nov 9, 2024
fulvius31
added a commit
to fulvius31/pytorch
that referenced
this pull request
Nov 11, 2024
In pytorch#140190 the base64 function is imported from triton But, since triton-lang/triton#5088 , the base64 function was replaced to base32
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Nov 12, 2024
In #140190 the base64 function is imported from triton But, since triton-lang/triton#5088 , the base64 function was replaced to base32 Pull Request resolved: #140297 Approved by: https://github.com/davidberard98
zhangxiaoli73
pushed a commit
to zhangxiaoli73/pytorch
that referenced
this pull request
Nov 13, 2024
In pytorch#140190 the base64 function is imported from triton But, since triton-lang/triton#5088 , the base64 function was replaced to base32 Pull Request resolved: pytorch#140297 Approved by: https://github.com/davidberard98
Luosuu
pushed a commit
to Luosuu/triton
that referenced
this pull request
Nov 13, 2024
…riton-lang#5088) Modify the _base64 function used for filename generation to ensure filenames do not start with a hyphen (`-`). This change prevents issues on Unix-like systems where filenames beginning with a hyphen can be misinterpreted as command-line options. in this way we adhere to to the [The Linux Information Project's File Naming Conventions](https://www.linfo.org/file_name.html): > "File names should never begin with a hyphen"
Ryo-not-rio
pushed a commit
to Ryo-not-rio/pytorch
that referenced
this pull request
Dec 2, 2024
In pytorch#140190 the base64 function is imported from triton But, since triton-lang/triton#5088 , the base64 function was replaced to base32 Pull Request resolved: pytorch#140297 Approved by: https://github.com/davidberard98
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
In pytorch#140190 the base64 function is imported from triton But, since triton-lang/triton#5088 , the base64 function was replaced to base32 Pull Request resolved: pytorch#140297 Approved by: https://github.com/davidberard98
fmo-mt
pushed a commit
to fmo-mt/pytorch
that referenced
this pull request
Dec 11, 2024
In pytorch#140190 the base64 function is imported from triton But, since triton-lang/triton#5088 , the base64 function was replaced to base32 Pull Request resolved: pytorch#140297 Approved by: https://github.com/davidberard98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the _base64 function used for filename generation to ensure filenames do not start with a hyphen (
-).Added
_ensure_safe_filenamefunction (called from the function created in #4553) in order to prepend an underscore (_) if the filename starts with a hyphen.This change prevents issues on Unix-like systems where filenames beginning with a hyphen can be misinterpreted as command-line options.
in this way we adhere to to the The Linux Information Project's File Naming Conventions:
A comparison:
The
test_core.pyruns without errors.The core Triton is a small number of people, and we receive many PRs (thank
you!). To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.
Complete the following tasks before sending your PR, and replace
[ ]with[x]to indicate you have done them.I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)