Skip to content

Improve offline builds #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jokeren merged 1 commit into from
Aug 5, 2024
Merged

Improve offline builds #4461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def is_offline_build() -> bool:

Note that this flag isn't tested by the CI and does not provide any guarantees.
"""
return os.environ.get("TRITON_OFFLINE_BUILD", "") != ""
return check_env_flag("TRITON_OFFLINE_BUILD", "")


# --- third party packages -----
Expand Down Expand Up @@ -450,6 +450,10 @@ def build_extension(self, ext):
else:
cmake_args += ["-DTRITON_BUILD_PROTON=OFF"]

if is_offline_build():
# unit test builds fetch googletests from GitHub
cmake_args += ["-DTRITON_BUILD_UT=OFF"]

cmake_args_append = os.getenv("TRITON_APPEND_CMAKE_ARGS")
if cmake_args_append is not None:
cmake_args += shlex.split(cmake_args_append)
Expand Down