Merged
Conversation
`is_offline_build()` now uses `check_env_flag()` like the rest of the `setup.py` code. `TRITON_OFFLINE_BUILD=YES` and `TRITON_OFFLINE_BUILD=NO` work as expected. Offline builds now disable unit test builds. The default `TRITON_BUILD_UT=YES` triggers a download of `googletests` code from GitHub. See: triton-lang#4414 Signed-off-by: Christian Heimes <christian@python.org>
Jokeren
approved these changes
Aug 5, 2024
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
`is_offline_build()` now uses `check_env_flag()` like the rest of the `setup.py` code. `TRITON_OFFLINE_BUILD=YES` and `TRITON_OFFLINE_BUILD=NO` work as expected. Offline builds now disable unit test builds. The default `TRITON_BUILD_UT=YES` triggers a download of `googletests` code from GitHub. See: triton-lang#4414 - [X] I am not making a trivial change, such as fixing a typo in a comment. - [X] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [X] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [X] This PR does not need a test because it improves the build system. - Select one of the following. - [X] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.) Signed-off-by: Christian Heimes <christian@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_offline_build()now usescheck_env_flag()like the rest of thesetup.pycode.TRITON_OFFLINE_BUILD=YESandTRITON_OFFLINE_BUILD=NOwork as expected.Offline builds now disable unit test builds. The default
TRITON_BUILD_UT=YEStriggers a download ofgoogletestscode from GitHub.See: #4414
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsSelect one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)