Bump LLVM version to llvm/llvm-project@49af650#2570
Merged
Conversation
This patch adds a text file that holds the LLVM commit hash to be used with the Triton code. Once the workflow files are added to the main branch, any updates to this text file in the llvm-head branch will trigger an LLVM build and the corresponding build artifacts will be uploaded to Azure Blob storage. Squashed commits: Bump LLVM version. Update LLVM version to llvm/llvm-project@0954dc3 update hash to 76ce4736721a update llvm hash: b1115f8ccefb380824a9d997622cc84fc0d84a89 [ci] now set LLVM_BUILD_TOOLS=ON in llvm-build.yml
…. `LLVM::AddressOfOp` now returns an opaque pointer by default.
|
|
jlebar
reviewed
Oct 31, 2023
| # use_assert_enabled_llvm = check_env_flag("TRITON_USE_ASSERT_ENABLED_LLVM", "False") | ||
| # release_suffix = "assert" if use_assert_enabled_llvm else "release" | ||
| rev = "b1115f8c" | ||
| rev = "49af6502" |
Contributor
There was a problem hiding this comment.
Can we read the value in llvm-hash.txt? (And update the README.md that currently points here?)
jlebar
reviewed
Oct 31, 2023
Contributor
There was a problem hiding this comment.
To avoid polluting the top-level directory, could we put this in the cmake directory? (Perhaps that should be renamed to build.)
Collaborator
Author
There was a problem hiding this comment.
Both comments make sense to me. But I think it would be best to do those in a separate PR, since updating the LLVM version itself is quite orthogonal from the process for doing it, and would require modifying the build system in several unrelated locations. WDYT?
Contributor
There was a problem hiding this comment.
@gflegar did you get around to making these changes?
jlebar
approved these changes
Oct 31, 2023
karupayun
added a commit
to karupayun/triton
that referenced
this pull request
Nov 22, 2023
In this PR we are deduplicating the llvm-hash value (currently it's in the llvm-hash.txt file but also under python/setup.py. The new location is cmake/llvm-hash.txt. Both changes were suggested by jlebar in triton-lang#2570.
karupayun
added a commit
that referenced
this pull request
Nov 23, 2023
In this PR we are deduplicating the llvm-hash value (currently it's in the llvm-hash.txt file but also under python/setup.py. The new location is cmake/llvm-hash.txt. Both changes were suggested by jlebar in #2570.
karupayun
added a commit
that referenced
this pull request
Nov 23, 2023
In this PR we are deduplicating the llvm-hash value (currently it's in the llvm-hash.txt file but also under python/setup.py. The new location is cmake/llvm-hash.txt. Both changes were suggested by jlebar in #2570.
karupayun
added a commit
to karupayun/triton
that referenced
this pull request
Nov 23, 2023
In this PR we are deduplicating the llvm-hash value (currently it's in the llvm-hash.txt file but also under python/setup.py. The new location is cmake/llvm-hash.txt. Both changes were suggested by jlebar in triton-lang#2570. Test: Pushed the same change to llvm-head branch. Trigger a llvm-build. It passed.
plotfi
pushed a commit
to plotfi/triton
that referenced
this pull request
Nov 26, 2023
…riton-lang#2698) In this PR we are deduplicating the llvm-hash value (currently it's in the llvm-hash.txt file but also under python/setup.py. The new location is cmake/llvm-hash.txt. Both changes were suggested by jlebar in triton-lang#2570. Test: Pushed the same change to llvm-head branch. Trigger a llvm-build (https://github.com/openai/triton/actions/runs/6970868398), it passed.
feihugis
pushed a commit
to feihugis/triton
that referenced
this pull request
Feb 13, 2024
…riton-lang#2698) In this PR we are deduplicating the llvm-hash value (currently it's in the llvm-hash.txt file but also under python/setup.py. The new location is cmake/llvm-hash.txt. Both changes were suggested by jlebar in triton-lang#2570. Test: Pushed the same change to llvm-head branch. Trigger a llvm-build (https://github.com/openai/triton/actions/runs/6970868398), it passed.
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
Co-authored-by: Ashay Rane <ashay@users.noreply.github.com> Co-authored-by: khasanovaa <khasanovaaliya19@gmail.com>
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
…riton-lang#2698) In this PR we are deduplicating the llvm-hash value (currently it's in the llvm-hash.txt file but also under python/setup.py. The new location is cmake/llvm-hash.txt. Both changes were suggested by jlebar in triton-lang#2570. Test: Pushed the same change to llvm-head branch. Trigger a llvm-build (https://github.com/openai/triton/actions/runs/6970868398), it passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.