[BUILD] Add TRITON_BUILD_WITH_ASAN envvar#2533
Merged
Merged
Conversation
This was referenced Oct 23, 2023
ThomasRaoux
approved these changes
Oct 23, 2023
Jokeren
changed the title
jlebar
force-pushed
the
jlebar/asan-build
branch
from
8f94354 to
8e47509
Compare
Note that asan doesn't work with programs that use the GPU, so this is only useful for running tools like triton-opt. I was not able to get msan working. libstdc++'s std::string implementation seems to use uninitialized memory in a way that seems safe but triggers an msan error. I tried and gave up on switching to libc++ and teaching msan to ignore this error. GPC: asan-build
jlebar
force-pushed
the
jlebar/asan-build
branch
from
8e47509 to
295550e
Compare
jlebar
force-pushed
the
jlebar/dead-vprintf
branch
from
d476314 to
8b50cfd
Compare
Contributor
Author
|
Thanks for the push, @ptillet. Re-opening this because
|
Contributor
Author
|
Ah, actually I cannot re-open the PR. Created #2536. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TRITON_BUILD_WITH_ASAN envvar.
Note that asan doesn't work with programs that use the GPU, so this is
only useful for running tools like triton-opt.
I was not able to get msan working. libstdc++'s std::string
implementation seems to use uninitialized memory in a way that seems
safe but triggers an msan error. I tried and gave up on switching to
libc++ and teaching msan to ignore this error.
PR chain
you're doing. This PR is part of a chain of PRs, and clicking the merge
button will not merge it into master.