[BACKEND] Delete dead vprintf and vprintf_array functions#2531
Merged
Conversation
This was referenced Oct 23, 2023
ThomasRaoux
approved these changes
Oct 23, 2023
Jokeren
changed the title
jlebar
force-pushed
the
jlebar/dead-vprintf
branch
2 times, most recently
from
f3c919c to
8b50cfd
Compare
jlebar
force-pushed
the
jlebar/dead-vprintf
branch
from
8b50cfd to
05876d1
Compare
Collaborator
|
not sure why it was hanging :O At first I thought it was the CI node, but another PR passed normally. It may be an unrelated flaky hang. Let me relaunch the job. |
jlebar
force-pushed
the
jlebar/dead-vprintf
branch
from
05876d1 to
6308407
Compare
jlebar
force-pushed
the
jlebar/asan-build
branch
from
c4ca9a0 to
566cab7
Compare
jlebar
force-pushed
the
jlebar/dead-vprintf
branch
from
6308407 to
7fcaed7
Compare
These were introduced in 88498d1 and appear to have been dead at the time of introduction. GPC: dead-vprintf
jlebar
force-pushed
the
jlebar/dead-vprintf
branch
from
7fcaed7 to
da2abfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete dead vprintf and vprintf_array functions.
These were introduced in 88498d1 and
appear to have been dead at the time of introduction.
PR chain