Skip to content

[PROTON] Reduce msgpack serialization overhead-4 #10396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jokeren merged 6 commits into from
May 29, 2026
Merged

[PROTON] Reduce msgpack serialization overhead-4 #10396

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d05277
Prune empty Proton MsgPack leaf frames
Jokeren May 27, 2026
39a9199
Keep concrete Proton children during MsgPack dump
Jokeren May 27, 2026
8544ad9
Match Proton concrete MsgPack traversal
Jokeren May 27, 2026
d6de9fc
Skip empty Proton concrete capture leaves
Jokeren May 27, 2026
377c1e1
Avoid repeated Proton concrete child filtering
Jokeren May 27, 2026
46e93a1
Use vectors for Proton child filtering
Jokeren May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 34 additions & 6 deletions third_party/proton/csrc/lib/Data/TreeData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,10 +712,22 @@ TreeData::buildHatchetMsgPack(TreeData::Tree *tree,
}
}
}
writer.packFixStrLiteral("children");
writer.packArray(static_cast<uint32_t>(virtualNode.children.size()));
// Linked flexible metrics attached to generated helper leaves are promoted
// into the parent metrics map above. Once promoted, a helper leaf with no
// linked fixed metrics and no children carries no information in Hatchet.
std::vector<size_t> linkedChildren;
linkedChildren.reserve(virtualNode.children.size());
for (const auto &child : virtualNode.children) {
packLinkedVirtualNode(packLinkedVirtualNode, treeNode, child.id);
const auto &childNode = virtualTree->getNode(child.id);
if (!childNode.children.empty() ||
linkedMetrics.find(child.id) != linkedMetrics.end()) {
linkedChildren.push_back(child.id);
}
}
writer.packFixStrLiteral("children");
writer.packArray(static_cast<uint32_t>(linkedChildren.size()));
for (auto childId : linkedChildren) {
packLinkedVirtualNode(packLinkedVirtualNode, treeNode, childId);
}
};
auto packNode = [&](auto &&packNode,
Expand All @@ -737,11 +749,27 @@ TreeData::buildHatchetMsgPack(TreeData::Tree *tree,
hasLinkedTargets
? static_cast<uint32_t>(virtualRootNode.children.size())
: 0;
// CUDA stream capture can create concrete launch-name leaves before the
// launch callback exits early without correlating metrics. Graph replay
// metrics are attached through linked virtual nodes instead, so a concrete
// leaf with no metrics, linked metrics, flexible metrics, or children adds
// no Hatchet information.
std::vector<TreeData::Tree::TreeNode *> concreteChildren;
concreteChildren.reserve(treeNode.children.size());
for (const auto &child : treeNode.children) {
auto &childNode = tree->getNode(child.id);
if (!childNode.children.empty() || !childNode.metricSet.metrics.empty() ||
!childNode.metricSet.flexibleMetrics.empty() ||
!childNode.metricSet.linkedMetrics.empty() ||
!childNode.metricSet.linkedFlexibleMetrics.empty()) {
concreteChildren.push_back(&childNode);
}
}
writer.packFixStrLiteral("children");
writer.packArray(static_cast<uint32_t>(treeNode.children.size()) +
writer.packArray(static_cast<uint32_t>(concreteChildren.size()) +
linkedChildCount);
for (const auto &child : treeNode.children) {
packNode(packNode, tree->getNode(child.id));
for (auto *childNode : concreteChildren) {
packNode(packNode, *childNode);
}
if (hasLinkedTargets) {
for (const auto &virtualChild : virtualRootNode.children) {
Expand Down
Loading