Skip to content

[PROTON] Reduce msgpack serialization overhead-4#10396

Merged
Jokeren merged 6 commits into
mainfrom
keren/proton-fast-file-write-leaves
May 29, 2026
Merged

[PROTON] Reduce msgpack serialization overhead-4#10396
Jokeren merged 6 commits into
mainfrom
keren/proton-fast-file-write-leaves

Conversation

@Jokeren
Copy link
Copy Markdown
Contributor

@Jokeren Jokeren commented May 27, 2026

Skip empty leaf nodes. We don't skip empty internal nodes to make the code simpler and more efficient. In fact, most empty nodes are leaves (kernels)

@Jokeren Jokeren requested review from CRobeck and fywkevin as code owners May 27, 2026 17:46
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-traversal branch from f15d12d to 7f6570b Compare May 27, 2026 18:20
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-leaves branch from fad65d9 to 750366b Compare May 27, 2026 18:20
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-traversal branch from 7f6570b to face54b Compare May 28, 2026 17:54
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-leaves branch 2 times, most recently from 82b7a63 to 654545f Compare May 28, 2026 18:24
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-traversal branch from face54b to bcda6ef Compare May 28, 2026 18:24
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-leaves branch from 654545f to 9bbebfd Compare May 29, 2026 02:14
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-traversal branch from bcda6ef to 0f8377e Compare May 29, 2026 02:14
Base automatically changed from keren/proton-fast-file-write-traversal to main May 29, 2026 11:50
@Jokeren Jokeren force-pushed the keren/proton-fast-file-write-leaves branch from 9bbebfd to 46e93a1 Compare May 29, 2026 12:03
@Jokeren Jokeren merged commit c5b3f3a into main May 29, 2026
10 checks passed
@Jokeren Jokeren deleted the keren/proton-fast-file-write-leaves branch May 29, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants