Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
/*
* Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/

#ifndef TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H
#define TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H

#include "mlir/IR/BuiltinOps.h"
#include "mlir/Pass/Pass.h"

namespace mlir {
namespace triton {

// AddMultiBufferCubeScopePass for adding cube core intra-loop multi-buffer
// optimization driven by `ssbuffer.cubeBuffer = [group, role]` attributes on
// producers (currently hivm.hir.fixpipe, role=1) and consumers (currently
// memref.memory_space_cast, role=0). For each (group, role=1)/(group,
// role=0) pair inside the main_loop of a CUBE scope, this pass:
// 1. Allocates N memref.alloc buffers (N read from ssbuffer.cube_buf_count).
// 2. Wraps producer/consumer with an scf.if chain selecting buffer[i] based
// on (iter_count % N).
class AddMultiBufferCubeScopePass
: public PassWrapper<AddMultiBufferCubeScopePass,
OperationPass<ModuleOp>> {
public:
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(AddMultiBufferCubeScopePass)

// Constructor
AddMultiBufferCubeScopePass() = default;

// Pass argument
StringRef getArgument() const override {
return "add_multi_buffer_cube_scope";
}

// Dependent dialects
void getDependentDialects(DialectRegistry &registry) const override;

// Run the pass
void runOnOperation() override;
};

// Create the pass
std::unique_ptr<OperationPass<ModuleOp>> createAddMultiBufferCubeScopePass();

// Register the pass
void registerAddMultiBufferCubeScopePasses();

} // namespace triton
} // namespace mlir

#endif // TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[style · low]
Missing trailing newline at end of file. The header file does not end with a newline character (as indicated by \ No newline at end of file in the diff). This can cause compiler warnings on some platforms (e.g., -Wnewline-eof in GCC/Clang) and breaks consistency with other header files in the project (e.g., Common/Utils.h ends with a proper newline).

Suggestion:

Suggested change
#endif // TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H
#endif // TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[style · low]
Missing trailing newline at end of file. The header file does not end with a newline character (as indicated by \ No newline at end of file in the diff). This can cause compiler warnings on some platforms (e.g., -Wnewline-eof in GCC/Clang) and breaks consistency with other header files in the project (e.g., Common/Utils.h ends with a proper newline).

Suggestion:

Suggested change
#endif // TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H
#endif // TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H

3 changes: 3 additions & 0 deletions third_party/ascend/include/DynamicCVPipeline/Common/Utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ inline constexpr llvm::StringLiteral kInterCoreBufCount =
"ssbuffer.inter_core_buf_count";
inline constexpr llvm::StringLiteral kLoadStoreBufCount =
"ssbuffer.load_store_buf_count";
inline constexpr llvm::StringLiteral kCubeBufCount =
"ssbuffer.cube_buf_count";
inline constexpr llvm::StringLiteral kCubeBuffer = "ssbuffer.cubeBuffer";
inline constexpr llvm::StringLiteral kAnalyzeFlagId =
"ssbuffer.analyze_flag_id";
inline constexpr llvm::StringLiteral kLoopCarriedL0C =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*/

#include "ascend/include/DynamicCVPipeline/AllocMultiCache.h"
#include "ascend/include/DynamicCVPipeline/AllocMultiCache/AddMultiBufferCubeScope.h"
#include "ascend/include/DynamicCVPipeline/AllocMultiCache/AddMultiBufferInnerScope.h"
#include "ascend/include/DynamicCVPipeline/AllocMultiCache/AddMultiBufferOuterScope.h"
#include "ascend/include/DynamicCVPipeline/Common/Utils.h"
Expand Down Expand Up @@ -54,7 +55,10 @@ void AllocMultiCachePass::runOnOperation() {
// Step 1:Inner multibuffer
pm.addPass(createAddMultiBufferInnerScopePass());

// Step 2: Outer multibuffer
// Step 2: Cube-core intra-loop multibuffer
pm.addPass(createAddMultiBufferCubeScopePass());

// Step 3: Outer multibuffer
pm.addPass(createAddMultiBufferOuterScopePass());

if (failed(runPipeline(pm, module))) {
Expand Down
Loading
Loading