【WIP】add cmb - #1527
Conversation
github-actions
Bot
added
compiler
|
🔍 OpenCodeReview found 2 issue(s) in this PR.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } // namespace triton | ||
| } // namespace mlir | ||
|
|
||
| #endif // TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H No newline at end of file |
There was a problem hiding this comment.
[style · low]
Missing trailing newline at end of file. The header file does not end with a newline character (as indicated by \ No newline at end of file in the diff). This can cause compiler warnings on some platforms (e.g., -Wnewline-eof in GCC/Clang) and breaks consistency with other header files in the project (e.g., Common/Utils.h ends with a proper newline).
Suggestion:
| #endif // TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H | |
| #endif // TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H |
| } // namespace triton | ||
| } // namespace mlir | ||
|
|
||
| #endif // TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H No newline at end of file |
There was a problem hiding this comment.
[style · low]
Missing trailing newline at end of file. The header file does not end with a newline character (as indicated by \ No newline at end of file in the diff). This can cause compiler warnings on some platforms (e.g., -Wnewline-eof in GCC/Clang) and breaks consistency with other header files in the project (e.g., Common/Utils.h ends with a proper newline).
Suggestion:
| #endif // TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H | |
| #endif // TRITON_ADAPTER_ALLOC_MULTI_CACHE_ADD_MULTI_BUFFER_CUBE_SCOPE_PASS_H |
1 participant
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)