Skip to content

Remove write only objects #8178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kokosing merged 4 commits into from
Apr 25, 2022
Merged

Remove write only objects #8178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ce4ce9
Remove write-only object from PluginManager
ksobolew Jun 2, 2021
17d260e
Remove obsolete field
ksobolew Jun 2, 2021
1e89506
Remove write-only objects from TestDbResourceGroupConfigurationManager
ksobolew Jun 2, 2021
31f8caa
Remove write-only object from TrinoStatement
ksobolew Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ public class TrinoStatement
private final AtomicLong maxRows = new AtomicLong();
private final AtomicInteger queryTimeoutSeconds = new AtomicInteger();
private final AtomicInteger fetchSize = new AtomicInteger();
private final AtomicBoolean escapeProcessing = new AtomicBoolean(true);
private final AtomicBoolean closeOnCompletion = new AtomicBoolean();
private final AtomicReference<TrinoConnection> connection;
private final Consumer<TrinoStatement> onClose;
Expand Down Expand Up @@ -161,7 +160,8 @@ public void setEscapeProcessing(boolean enable)
throws SQLException
{
checkOpen();
escapeProcessing.set(enable);
// Escape processing is not implemented. JDBC mandates that escapes processing is enabled by default,
// so throwing here doesn't make sense.
}

@Override
Expand Down
3 changes: 0 additions & 3 deletions core/trino-main/src/main/java/io/trino/server/PluginManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ public class PluginManager
private final BlockEncodingManager blockEncodingManager;
private final HandleResolver handleResolver;
private final AtomicBoolean pluginsLoading = new AtomicBoolean();
private final AtomicBoolean pluginsLoaded = new AtomicBoolean();

@Inject
public PluginManager(
Expand Down Expand Up @@ -137,8 +136,6 @@ public void loadPlugins()
pluginsProvider.loadPlugins(this::loadPlugin, PluginManager::createClassLoader);

typeRegistry.verifyTypes();

pluginsLoaded.set(true);
}

private void loadPlugin(String plugin, Supplier<PluginClassLoader> createClassLoader)
Expand Down
2 changes: 0 additions & 2 deletions .../main/java/io/trino/plugin/raptor/legacy/storage/organization/ShardCompactionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ public class ShardCompactionManager
private final ScheduledExecutorService compactionDiscoveryService = newScheduledThreadPool(1, daemonThreadsNamed("shard-compaction-discovery"));

private final AtomicBoolean discoveryStarted = new AtomicBoolean();
private final AtomicBoolean shutdown = new AtomicBoolean();

private final MetadataDao metadataDao;
private final ShardOrganizer organizer;
Expand Down Expand Up @@ -141,7 +140,6 @@ public void shutdown()
if (!compactionEnabled) {
return;
}
shutdown.set(true);
compactionDiscoveryService.shutdown();
}

Expand Down
8 changes: 2 additions & 6 deletions .../test/java/io/trino/plugin/resourcegroups/db/TestDbResourceGroupConfigurationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import java.util.List;
import java.util.Optional;
import java.util.concurrent.ThreadLocalRandom;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.regex.Pattern;

import static com.google.common.util.concurrent.MoreExecutors.directExecutor;
Expand Down Expand Up @@ -115,11 +114,9 @@ public void testConfiguration()
dao.insertResourceGroup(2, "sub", "2MB", 4, 3, 3, null, 5, null, null, null, 1L, ENVIRONMENT);
dao.insertSelector(2, 1, null, null, null, null, null, null);
DbResourceGroupConfigurationManager manager = new DbResourceGroupConfigurationManager(listener -> {}, new DbResourceGroupConfig(), daoProvider.get(), ENVIRONMENT);
AtomicBoolean exported = new AtomicBoolean();
InternalResourceGroup global = new InternalResourceGroup("global", (group, export) -> exported.set(export), directExecutor());
InternalResourceGroup global = new InternalResourceGroup("global", (group, export) -> {}, directExecutor());
manager.configure(global, new SelectionContext<>(global.getId(), new ResourceGroupIdTemplate("global")));
assertEqualsResourceGroup(global, "1MB", 1000, 100, 100, WEIGHTED, DEFAULT_WEIGHT, true, Duration.ofHours(1), Duration.ofDays(1));
exported.set(false);
InternalResourceGroup sub = global.getOrCreateSubGroup("sub");
manager.configure(sub, new SelectionContext<>(sub.getId(), new ResourceGroupIdTemplate("global.sub")));
assertEqualsResourceGroup(sub, "2MB", 4, 3, 3, FAIR, 5, false, Duration.ofMillis(Long.MAX_VALUE), Duration.ofMillis(Long.MAX_VALUE));
Expand Down Expand Up @@ -195,8 +192,7 @@ public void testReconfig()
dao.insertResourceGroupsGlobalProperties("cpu_quota_period", "1h");
DbResourceGroupConfigurationManager manager = new DbResourceGroupConfigurationManager(listener -> {}, new DbResourceGroupConfig(), daoProvider.get(), ENVIRONMENT);
manager.start();
AtomicBoolean exported = new AtomicBoolean();
InternalResourceGroup global = new InternalResourceGroup("global", (group, export) -> exported.set(export), directExecutor());
InternalResourceGroup global = new InternalResourceGroup("global", (group, export) -> {}, directExecutor());
manager.configure(global, new SelectionContext<>(global.getId(), new ResourceGroupIdTemplate("global")));
InternalResourceGroup globalSub = global.getOrCreateSubGroup("sub");
manager.configure(globalSub, new SelectionContext<>(globalSub.getId(), new ResourceGroupIdTemplate("global.sub")));
Expand Down