Merged
Conversation
Praveen2112
reviewed
Jun 4, 2021
core/trino-main/src/main/java/io/trino/server/PluginManager.java
Outdated
Show resolved
Hide resolved
client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoStatement.java
Outdated
Show resolved
Hide resolved
ksobolew
force-pushed
the
ksob/remove-write-only-objects
branch
from
f2f8b36 to
50d8f23
Compare
findepi
reviewed
Jun 7, 2021
client/trino-jdbc/src/main/java/io/trino/jdbc/TrinoStatement.java
Outdated
Show resolved
Hide resolved
Member
|
lgtm % #8178 (comment) |
ksobolew
force-pushed
the
ksob/remove-write-only-objects
branch
from
50d8f23 to
cd5b134
Compare
ksobolew
force-pushed
the
ksob/remove-write-only-objects
branch
from
cd5b134 to
8e5fa14
Compare
kokosing
approved these changes
Apr 7, 2022
lukasz-walkiewicz
approved these changes
Apr 7, 2022
ksobolew
force-pushed
the
ksob/remove-write-only-objects
branch
from
8e5fa14 to
31f8caa
Compare
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a result of going through Trino code with the new inspection added in IntelliJ IDEA 2021.2
The removed objects are in some years-old code, and they were either never actually read from, or they were left behind after a cleanup. I don't think any of this is actually a bug (with the possible exception of the one in
TrinoStatement#setEscapeProcessing).