Avoid including hive views in iceberg SHOW TABLES

[raunaqmorarka]

No description provided.

[findepi]

LGTM

Please add a test exercising Hive and Iceberg using same backing metastore.
This should be a product test to get good coverage of metastore-dependent interactions like this. (For example -- can getTablesWithParameter be used with TABLE_COMMENT property?)

[raunaqmorarka]

LGTM

Please add a test exercising Hive and Iceberg using same backing metastore.
This should be a product test to get good coverage of metastore-dependent interactions like this. (For example -- can getTablesWithParameter be used with TABLE_COMMENT property?)

Thanks for pointing out, turns out TABLE_PARAMETER_SAFE_VALUE_PATTERN blocks our parameter value, i'll need to tweak that a bit

[findepi]

Your value is not far from matching TABLE_PARAMETER_SAFE_VALUE_PATTERN

based on the code comment:

the HMS may want the parameter
* value to follow a Java regex pattern or a SQL pattern

seems like we could allow spaces in TABLE_PARAMETER_SAFE_VALUE_PATTERN.

[raunaqmorarka]

Your value is not far from matching TABLE_PARAMETER_SAFE_VALUE_PATTERN

based on the code comment:

the HMS may want the parameter

• value to follow a Java regex pattern or a SQL pattern

seems like we could allow spaces in TABLE_PARAMETER_SAFE_VALUE_PATTERN.

I got things working for iceberg by allowing spaces in TABLE_PARAMETER_SAFE_VALUE_PATTERN.
Also added a product test.
But I also see that in shared metastore setup, hive connector lists all the iceberg tables and MVs with same schema name because it calls getAllTables
In shared setup, are we mainly concerned about the iceberg side or the hive side listings also need to work correctly ?

[anjalinorwood]

LGTM!

[sopel39]

please create an issue in Github and reference it here

[raunaqmorarka]

This should get solved by #8113

[sopel39]

is storage table created immediately?

[raunaqmorarka]

yes, in iceberg CREATE MV we create the storage table even before storing the MV definition in HMS