Add listMaterializedViews and getMaterializedViews SPI#8113
Merged
sopel39 merged 6 commits intotrinodb:masterfrom Jun 7, 2021
Merged
Add listMaterializedViews and getMaterializedViews SPI#8113sopel39 merged 6 commits intotrinodb:masterfrom
sopel39 merged 6 commits intotrinodb:masterfrom
Conversation
Member
|
@raunaqmorarka i am adding more tests, inclduding a bit of information_schema coverage for MVs in #8117 |
Member
Author
Looked at it, since i've tested similar cases in this PR, I think it should result in the |
Member
Author
|
@findepi I've rebased this to master and added changes to BaseConnectorTest#testMaterializedView |
sopel39
reviewed
May 31, 2021
core/trino-main/src/main/java/io/trino/security/AccessControl.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
would it be possible to add test to TestInformationSchemaConnector or TestInformationSchemaMetadata?
Member
Author
There was a problem hiding this comment.
This is covered by BCT column listing tests
findepi
reviewed
May 31, 2021
...ino-main/src/main/java/io/trino/connector/informationschema/InformationSchemaPageSource.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/system/jdbc/TableJdbcTable.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataListing.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/system/jdbc/ColumnJdbcTable.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/rewrite/ShowQueriesRewrite.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMaterializedViews.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
list-mvs
branch
4 times, most recently
from
be5afc5 to
b99061e
Compare
sopel39
approved these changes
Jun 2, 2021
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
Member
|
please rebase on top of #8153 |
Member
Author
done |
sopel39
approved these changes
Jun 7, 2021
...ino-main/src/main/java/io/trino/connector/informationschema/InformationSchemaPageSource.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
Added tests for information_schema.tables and system.jdbc.tables
Fixed and added tests for DESCRIBE, SHOW COLUMNS, information_schema.columns and system.jdbc.columns
sopel39
reviewed
Jun 7, 2021
| { | ||
| Set<SchemaTableName> tables = listTables(session, metadata, accessControl, prefix); | ||
| Set<SchemaTableName> views = listViews(session, metadata, accessControl, prefix); | ||
| // TODO (https://github.com/trinodb/trino/issues/8207) define a type for materialized views |
Member
There was a problem hiding this comment.
nit: this should be separate commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used listMaterializedViews to list MV names for information_schema.tables, system.jdbc.tables and SHOW TABLES
Used getMaterializedViews to list MV columns in information_schema.columns, system.jdbc.columns and SHOW COLUMNS
Fixed DESCRIBE, SHOW COLUMNS, information_schema.columns, system.jdbc.columns for MVs in Iceberg.
Table type used for MVs in information_schema.tables is left unchanged as BASE TABLE.
MVs are not listed in information_schema.views.
getMaterializedViews can be used in future to introduce information_schema.trino_materialized_views or system.metadata.materialized_views for showing detailed information about materialized view definitions.