Added a fix for BQ connector to correctly treat single quote in query criteria

[ayushbilala]

Fix for #7784.

Added a change to properly rewrite filter values containing the ANSI SQL single quote Escape sequence into the one that BigQuery is happy with.

Example:
'Looney''s Lane' string in Presto query filter will be changed to 'Looney\'s Lane' in order to make the query work.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ayush Bilala.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[hashhar]

Thanks for sending a PR.

It'd be nice to also handle other possible cases. It can be part of a follow-up if needed.
Please also change the commit message to describe the fix instead of referencing a GitHub issue. You can comment in the PR description as Fixes #7784 instead.

[hashhar]

It'd be nice to handle all possible characters that need escaping.

If possible can you also add support for the ones listed at https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#string_and_bytes_literals along with test-cases?

[ayushbilala]

Sure, let me take a look and figure out what does it actually take to add escaping for all possible characters.
If it is too much effort, I'll probably take it up as a follow-up.

[ayushbilala]

@hashhar Adding support for other literals doesn't look straightforward. Is it fine if we go ahead with this one and I'll do some more research and raise a separate issue for other characters?

[hashhar]

Please create an issue with your findings and add a TODO comment here so that we don't forget.

cc: @ebyhr

[ayushbilala]

Sure, I am on it.

[ayushbilala]

Created an issue for adding support for all characters #7900.
Added a TODO comment.

[ebyhr]

Thanks for fixing this. Understood remained patterns will be handled in #7900.

Left only minor comments. Please squash commits into one and update the commit title as
Escape single quote in BigQuery string condition

[hashhar]

@ayushbilala Please squash the commits and amend commit message as suggested by @ebyhr in #7869 (review).

@ebyhr I've verified TestBigQueryIntegrationSmokeTest passes.

[ebyhr]

Merged, thanks!