Fix BigQuery predicate pushdown for varchars with backslashes or newlines#14254
Fix BigQuery predicate pushdown for varchars with backslashes or newlines#14254
Conversation
hashhar
left a comment
There was a problem hiding this comment.
Looks good.
We don't have explicit tests for some escape sequences but looking at the table on https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#string_and_bytes_literals it seems like escaping \ properly and handling embedded newlines should cover most cases.
|
I don't think it's readonable to test all possible BigQuery sequences, because we actually don't generate them. |
|
CI |
That's what I meant by we should be fine as long as we escape quotes and backslash properly. |
|
looks like failure is related |
Backslashes require escaping, since they are used to escape apostrophes (and there are also other scape sequences). This is test-covered by an existing test, that's currently failing on master.
BigQuery string literals cannot contain new lines, require escape sequence.
2318f4f to
edf46fb
Compare
|
(just rebased) |
edf46fb to
007583a
Compare
4c3e756 to
af45cb4
Compare
|
cc @alexjo2144 |
|
redis failure seems unrelated |
|
CI #14035 |
Fixes tests failing on master since #14125 (past 6 days)
Fixes #7900
Follows #7869