Add instructions on how to start Elasticsearch#3331
Merged
martint merged 1 commit intotrinodb:masterfrom Apr 5, 2020
Merged
Conversation
findepi
approved these changes
Apr 3, 2020
presto-elasticsearch/src/test/java/io/prestosql/elasticsearch/ElasticsearchQueryRunner.java
Outdated
Show resolved
Hide resolved
Member
|
thanks! |
martint
force-pushed
the
elastic-runner
branch
2 times, most recently
from
c41f4d1 to
8be749d
Compare
electrum
approved these changes
Apr 4, 2020
Member
electrum
left a comment
electrum
left a comment
There was a problem hiding this comment.
We might want to make the query runner start and manage it automatically, like some of the others do.
Member
Author
See discussion in #3322 (comment) |
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Dec 14, 2022
Cherry-pick of trinodb/trino#3331 Co-authored-by: Martin Traverso <mtraverso@gmail.com>
zhenxiao
pushed a commit
to prestodb/presto
that referenced
this pull request
Dec 20, 2022
Cherry-pick of trinodb/trino#3331 Co-authored-by: Martin Traverso <mtraverso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.