Start ES in ElasticsearchQueryRunner.main

[findepi]

Otherwise main() obviously fails.

[martint]

Not if you’re running ES externally... It’s intentional that main() doesn’t start it.

[findepi]

This makes this class usable for everyone, and consistent with main() methods in other runners.

Support for localhost:9200 ES should be an opt-in.
For now, If you already take an effort to run ES manually, you can change the code to use that.
If this is common, we can add switches.

[martint]

This makes this class usable for everyone, and consistent with main() methods in other runners.

Consistency was never a goal. Being able to quickly develop and test changes to the ES connector is.

For now, If you already take an effort to run ES manually, you can change the code to use that.

That's precisely what I wanted to avoid when rewrote the connector -- carrying a set of changes as I'm developing just to be able to connect to a separate instance gets cumbersome and painful quickly.

If this is common

It most definitely is. TPC-H is woefully inadequate to be able to develop and test everything ES and the connector needs to be able to do. You need to load custom data, call ES APIs, etc.

[findepi]

@martint i am closign this

can you tell me how should i use this main method without the change?
maybe we could even add this as a comment there?

[martint]

maybe we could even add this as a comment there?

I will do that.

I'm also ok with adding a switch -- I just don't want to have to modify code every time I'm testing something.

[martint]

#3331