Skip to content

Add support for Glue endpoint URL#3239

Merged
sopel39 merged 1 commit intotrinodb:masterfrom
ppalucha:add-glue-endpoint
Apr 1, 2020
Merged

Add support for Glue endpoint URL#3239
sopel39 merged 1 commit intotrinodb:masterfrom
ppalucha:add-glue-endpoint

Conversation

@ppalucha
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Mar 25, 2020
@ppalucha ppalucha requested a review from sopel39 March 25, 2020 14:37
@ppalucha
Copy link
Member Author

Tested manually, but it requires -Dcom.amazonaws.sdk.disableCertChecking=true, due to misalignment between cert name (glue..amazonaws.com) and actual hostname used in endpoint.

@ppalucha
Copy link
Member Author

ppalucha commented Mar 27, 2020

Tested manually, but it requires -Dcom.amazonaws.sdk.disableCertChecking=true, due to misalignment between cert name (glue..amazonaws.com) and actual hostname used in endpoint.

Fixed by providing SSL Factory with NoopHostnameVerifier.

@sopel39
Copy link
Member

sopel39 commented Mar 27, 2020

Please reabase instead of merge commit

@ppalucha ppalucha requested a review from sopel39 March 27, 2020 15:27
@ppalucha ppalucha requested a review from electrum April 1, 2020 10:53
@sopel39 sopel39 merged commit 728be1a into trinodb:master Apr 1, 2020
@sopel39 sopel39 mentioned this pull request Apr 1, 2020
8 tasks
@martint martint added this to the 332 milestone Apr 9, 2020
aweisberg pushed a commit to v-jizhang/presto that referenced this pull request May 12, 2021
Cherry pick of trinodb/trino#3239

Co-authored-by: Pawel Palucha <pawel.palucha@starburstdata.com>
Co-authored-by: Ashhar Hasan <hashhar_dev@outlook.com>
arhimondr pushed a commit to prestodb/presto that referenced this pull request May 13, 2021
Cherry pick of trinodb/trino#3239

Co-authored-by: Pawel Palucha <pawel.palucha@starburstdata.com>
Co-authored-by: Ashhar Hasan <hashhar_dev@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants