Skip to content

Comments

Add support for Glue endpoint URL#16014

Merged
arhimondr merged 1 commit intoprestodb:masterfrom
v-jizhang:aws_endpoint
May 13, 2021
Merged

Add support for Glue endpoint URL#16014
arhimondr merged 1 commit intoprestodb:masterfrom
v-jizhang:aws_endpoint

Conversation

@v-jizhang
Copy link
Contributor

@v-jizhang v-jizhang commented Apr 27, 2021

Cherry pick of trinodb/trino#3239

Co-authored-by: Pawel Palucha pawel.palucha@starburstdata.com

== RELEASE NOTES ==

Hive Connector Changes
* Add support for Glue endpoint URL
  :doc:`/connector/hive`

Copy link
Member

@agrawalreetika agrawalreetika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a clean cherry-pick.
@v-jizhang Could you please add documentation for the property?
Code and tests look good to me.

@v-jizhang
Copy link
Contributor Author

This looks like a clean cherry-pick.
@v-jizhang Could you please add documentation for the property?
Code and tests look good to me.

Sure, thank you.

@v-jizhang
Copy link
Contributor Author

@agrawalreetika Other properties have been added by #16018.

@agrawalreetika
Copy link
Member

@v-jizhang I think, it would be good to add documentation with the specific feature PR.

@v-jizhang
Copy link
Contributor Author

@v-jizhang I think, it would be good to add documentation with the specific feature PR.

Created PR #16058

Copy link
Member

@agrawalreetika agrawalreetika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cherry pick of trinodb/trino#3239

Co-authored-by: Pawel Palucha <pawel.palucha@starburstdata.com>
Co-authored-by: Ashhar Hasan <hashhar_dev@outlook.com>
@aweisberg aweisberg requested review from arhimondr and rschlussel May 12, 2021 19:55
@arhimondr arhimondr merged commit 012e9bd into prestodb:master May 13, 2021
@sujay-jain sujay-jain mentioned this pull request May 21, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants