Run only CTAS in Redshift FTE smoke test#29137
Merged
Conversation
ebyhr
force-pushed
the
user/ebi/redshift-fte
branch
from
4d5aa1f to
6459ad5
Compare
chenjian2664
approved these changes
Apr 16, 2026
Contributor
chenjian2664
left a comment
chenjian2664
left a comment
There was a problem hiding this comment.
Can we also rename the test class if possible?
wendigo
approved these changes
Apr 16, 2026
findinpath
reviewed
Apr 16, 2026
| .cleansUpTemporaryTables(); | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
The commit message says what the code changes do.
However, it doesn't contain a rationale about why they have been done.
In any case, if deleting the ephemeral redshift cluster takes a long time (20min+), it doesn't necessarily bring much if we run just one test because in the end the build job will still fail :(
Maybe it is worth exploring using Redshift serverless.
Member
Author
Please feel free to rename as a follow-up. I couldn't think of a better name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of TestRedshiftQueryFailureRecoverySmokeTest is to run CTAS only.
However, it currently runs all FTE tests.
trino-redshift#18480Release notes
(x) This is not user-visible or is docs only, and no release notes are required.