Skip to content

Create a fault tolerant execution smoke test for trino-redshift#18480

Merged
findepi merged 1 commit intotrinodb:masterfrom
findinpath:findinpath/trino-redshift-fte-smoke-tests
Aug 3, 2023
Merged

Create a fault tolerant execution smoke test for trino-redshift#18480
findepi merged 1 commit intotrinodb:masterfrom
findinpath:findinpath/trino-redshift-fte-smoke-tests

Conversation

@findinpath
Copy link
Copy Markdown
Contributor

@findinpath findinpath commented Aug 1, 2023

Description

Opt for a smoke test to verify basic functionality of a CTAS statement on the trino-redshift connector.
Running all the fault tolerant execution tests on the connector can occasionally lead to timeouts due to the random geographical positioning of the Github CI runner in relation to the ephemeral AWS Redshift instance.

Local test run of the fault tolerant smoke tests completed locally in ~ 4 minutes.

Fixes #18446

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 1, 2023
@findinpath findinpath self-assigned this Aug 1, 2023
@findinpath findinpath requested review from ebyhr, findepi and hashhar August 1, 2023 10:41
Comment thread plugin/trino-redshift/pom.xml Outdated
@findinpath findinpath force-pushed the findinpath/trino-redshift-fte-smoke-tests branch from 9cfd583 to 0bfd826 Compare August 1, 2023 11:09
@findepi
Copy link
Copy Markdown
Member

findepi commented Aug 2, 2023

/test-with-secrets sha=a16052b87f889b2a271c8f1f3cb1bbc85fdd6fa2

Opt for a smoke test to verify basic functionality of a CTAS statement
on the `trino-redshift` connector.
Running all the fault-tolerant execution tests on the connector can
occasionally lead to timeouts due to the random geographical positioning
of the Github CI runner in relation to the ephemeral AWS Redshift instance.
@findinpath findinpath force-pushed the findinpath/trino-redshift-fte-smoke-tests branch from a16052b to b8c19b0 Compare August 2, 2023 07:35
@findinpath
Copy link
Copy Markdown
Contributor Author

@findepi pls trigger again the build with secrets

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Aug 2, 2023

/test-with-secrets sha=b8c19b02ed8202abfb7f17246b0915958ab4247c

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 3, 2023

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/5744938013

@findepi
Copy link
Copy Markdown
Member

findepi commented Aug 3, 2023

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/5744938013

green

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Aug 3, 2023
@findepi findepi merged commit f5eddd8 into trinodb:master Aug 3, 2023
@findepi findepi added the test label Aug 3, 2023
@github-actions github-actions bot added this to the 423 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry test

Development

Successfully merging this pull request may close these issues.

Timeout test (plugin/trino-redshift, fte-tests) job

4 participants