Unmark updateCount as nullable in QueryResults#27992
Merged
wendigo merged 1 commit intotrinodb:masterfrom Jan 23, 2026
Merged
Conversation
Since it was refactored to be an OptionalInt, it's required in the constructor to be non-null so it never actually is and annotation is no longer correct.
Merged
findepi
approved these changes
Jan 23, 2026
findepi
reviewed
Jan 23, 2026
| return updateType; | ||
| } | ||
|
|
||
| @Nullable |
Member
There was a problem hiding this comment.
i wish there was a static check for that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it was refactored to be an OptionalInt, it's required in the constructor to be non-null so it never actually is and annotation is no longer correct.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: