Skip to content

QueryResults cleanup#25070

Merged
wendigo merged 13 commits intomasterfrom
serafin/cleanup-query-result
Feb 19, 2025
Merged

QueryResults cleanup#25070
wendigo merged 13 commits intomasterfrom
serafin/cleanup-query-result

Conversation

@wendigo
Copy link
Copy Markdown
Contributor

@wendigo wendigo commented Feb 18, 2025

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 18, 2025
@wendigo wendigo requested a review from losipiuk February 18, 2025 16:44
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label Feb 18, 2025
@wendigo wendigo force-pushed the serafin/cleanup-query-result branch 2 times, most recently from 9c56593 to 50318e7 Compare February 18, 2025 20:18
@wendigo wendigo requested review from ebyhr and electrum February 18, 2025 20:25
Comment thread core/trino-main/src/main/java/io/trino/server/protocol/QueryResultRows.java Outdated
@wendigo wendigo force-pushed the serafin/cleanup-query-result branch from 50318e7 to 722aa96 Compare February 19, 2025 13:27
@wendigo wendigo merged commit 4cc721b into master Feb 19, 2025
@wendigo wendigo deleted the serafin/cleanup-query-result branch February 19, 2025 13:32
@github-actions github-actions bot added this to the 471 milestone Feb 19, 2025
@JsonProperty
@Override
public Long getUpdateCount()
public OptionalLong getUpdateCount()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove @Nullable now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed jdbc Relates to Trino JDBC driver

Development

Successfully merging this pull request may close these issues.

3 participants