Skip to content

Add new waiting strategy and timeout guards to Exasol container creation #27941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Mar 27, 2026
Merged

Add new waiting strategy and timeout guards to Exasol container creation #27941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions ...her/src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodeExasol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,11 @@
import io.trino.tests.product.launcher.env.common.TestsEnvironment;
import io.trino.tests.product.launcher.testcontainers.PortBinder;
import org.testcontainers.containers.startupcheck.IsRunningStartupCheckStrategy;
import org.testcontainers.containers.wait.strategy.Wait;
import org.testcontainers.containers.wait.strategy.WaitStrategy;

import java.time.Duration;

import static io.trino.tests.product.launcher.docker.ContainerUtil.forSelectedPorts;
import static io.trino.tests.product.launcher.env.EnvironmentContainers.configureTempto;
import static java.util.Objects.requireNonNull;
import static org.testcontainers.utility.MountableFile.forHostPath;
Expand Down Expand Up @@ -57,11 +60,33 @@ public void extendEnvironment(Builder builder)
private DockerContainer createExasol()
{
DockerContainer container = new DockerContainer("exadockerci4/docker-db:2025.1.8_dev_java_slc_only", "exasol") //Test container tailored to reduce used disk space and solve CI disk space pressure issue.
.withStartupCheckStrategy(new IsRunningStartupCheckStrategy())
.waitingFor(forSelectedPorts(EXASOL_PORT))
.withStartupCheckStrategy(new IsRunningStartupCheckStrategy().withTimeout(Duration.ofSeconds(10)))
.waitingFor(exasolReadyViaCurl())
Comment thread
pj-spoelders marked this conversation as resolved.
.withEnv("COSLWD_ENABLED", "1"); //Disables rsyslogd, cleans up log clutter and speeds up database startup
container.setPrivilegedMode(true);
portBinder.exposePort(container, EXASOL_PORT);
return container;
}

private static WaitStrategy exasolReadyViaCurl()
{
String command = """
bash -c '
while true; do
resp=$(curl -sk --max-time 5 https://localhost:%d/ 2>/dev/null || true)
if [ -n "$resp" ] && (
echo "$resp" | grep -q "status" ||
echo "$resp" | grep -q "WebSocket" ||
echo "$resp" | grep -q "error"
); then
exit 0
fi
sleep 0.5
done'
Comment thread
pj-spoelders marked this conversation as resolved.
""".formatted(EXASOL_PORT);

return Wait.forSuccessfulCommand(command)
.withStartupTimeout(Duration.ofMinutes(5));
}

}