Add new waiting strategy and timeout guards to Exasol container creation#27941
Merged
findepi merged 1 commit intotrinodb:masterfrom Mar 27, 2026
Merged
Conversation
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
from
577ada2 to
b394e4c
Compare
pj-spoelders
changed the title
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
6 times, most recently
from
440c4f3 to
edcab9c
Compare
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
2 times, most recently
from
2e8c138 to
8921de0
Compare
findepi
added
the
no-release-notes
Member
|
@pj-spoelders the build isn't quite green. if this is not related to this PR, please rebase |
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
from
8921de0 to
e3b66a8
Compare
Contributor
Author
|
I've rebased @findepi |
findepi
requested review from
Praveen2112 and
ebyhr
and removed request for
Praveen2112
ebyhr
reviewed
Feb 9, 2026
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
2 times, most recently
from
6642a90 to
d690fb1
Compare
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
2 times, most recently
from
c6fbbfa to
5be8578
Compare
Member
@pj-spoelders The default timeout is 30s (StartupCheckStrategy.timeout), right? How does this change (30s → 10s) resolve the hanging issue? |
ebyhr
force-pushed
the
exasol_wait_strategy_update
branch
from
5be8578 to
d44b0c3
Compare
Contributor
Author
It is the |
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
4 times, most recently
from
c7b810c to
ce06b7b
Compare
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
3 times, most recently
from
c30d80b to
54f81e9
Compare
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
2 times, most recently
from
aa9cb27 to
7422422
Compare
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
2 times, most recently
from
1f2f751 to
66e022f
Compare
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
from
66e022f to
81e716c
Compare
vlad-lyutenko
approved these changes
Mar 19, 2026
Contributor
|
Looks like all comments addressed, LGTM |
pj-spoelders
force-pushed
the
exasol_wait_strategy_update
branch
from
81e716c to
e72896e
Compare
Member
|
Thank you @pj-spoelders for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to waiting strategies used for the Exasol docker container to come up for the product tests:
We've replaced the old port waiting strategy with a curl script that checks if Exasol is up and properly responding.
We've also added a timeout guard to both waiting strategies: This should solve the issue with product tests hanging if the database doesn't properly start.
Additional context and related issues
This was done in light of: #27339
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: