Deprecate join-pushdown.with-expressions config property #27498
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
approved these changes
Nov 28, 2025
| return complexJoinPushdownEnabled; | ||
| } | ||
|
|
||
| @Deprecated |
Member
There was a problem hiding this comment.
This does not help users.
The best way is to rename the property to deprecated.join-.... That way it is clear to them that they need to stop using it soon.
Member
Author
There was a problem hiding this comment.
this triggers a warning during server startup if config property is still used
i agree than rename is much easier to nice (fails startup).
breaking without a warning upfront sounds not nice, but then it would require deprecate => rename => remove, 3 step process
airlift/airlift#756 was meant to help with this in a structured manner
btw i always though that prop names with "deprecated." are originally added as such?
Member
There was a problem hiding this comment.
I renamed like that few properties.
Deprecate `join-pushdown.with-expressions` config property and associated `complex_join_pushdown_enabled` session property. It was added for transition period when join pushdown behavior was being build out. Removing it will allow simplifying code.
findepi
force-pushed
the
findepi/deprecate-join-pushdown-with-expressions-config-property-4637e9
branch
from
ebcd45f to
701c4e0
Compare
kokosing
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
join-pushdown.with-expressionsconfig property and associatedcomplex_join_pushdown_enabledsession property. It was added for transition period when join pushdown behavior was being build out. Removing it will allow simplifying code.