Fix EXPLAIN (TYPE IO) failure when constraint contains type which cannot be cast to varchar#27433
Merged
findepi merged 3 commits intotrinodb:masterfrom Nov 27, 2025
Merged
Conversation
Member
|
Can we add some test case to this changes |
Avoid exception if constraint contain type which can't cast to varchar
hqbhoho
force-pushed
the
fix/explain_io
branch
from
47b04e4 to
50816d9
Compare
Praveen2112
approved these changes
Nov 26, 2025
core/trino-main/src/main/java/io/trino/sql/planner/planprinter/IoPlanPrinter.java
Show resolved
Hide resolved
findepi
changed the title
EXPLAIN (TYPE IO) failure when constraint contains type which cannot be cast to varchar
findepi
approved these changes
Nov 27, 2025
| discreteValues -> formattedRanges.addAll( | ||
| discreteValues.getValues().stream() | ||
| .map(value -> valuePrinter.castToVarcharOrFail(type, value)) | ||
| .map(value -> valuePrinter.castToVarchar(type, value)) |
Member
There was a problem hiding this comment.
castToVarchar is misnamed, exactly because may return something else when cast would fail
calling it "toPrintable" or "toString" would be better.
Let's rename as a separate PR (before or after this one)
Contributor
Author
There was a problem hiding this comment.
okk, I will file a new PR to rename castToVarchar to toString and remove castToVarcharOrFail after this one merged.
kasiafi
approved these changes
Nov 27, 2025
Contributor
|
@hqbhoho The pr got merged, FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid exception if constraint contain type which can't cast to varchar
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text: