Skip to content

Add regression test for IS NOT DISTINCT FROM pushdown correctness #27242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
+11 −0
Merged

Add regression test for IS NOT DISTINCT FROM pushdown correctness #27242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5724c87
Add test for IS NOT DISTINCT FROM pushdown in Iceberg
hqbhoho Nov 8, 2025
ce24b61
Add test for IS NOT DISTINCT FROM pushdown in DeltaLake
hqbhoho Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .../trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,13 @@ public void testTimestampWithTimeZoneOptimization()
.isFullyPushedDown()
.returnsEmptyResult();

assertThat(query("SELECT * FROM " + tableName + " WHERE year(part) IS DISTINCT FROM 2006"))
.isNotFullyPushedDown(FilterNode.class);

assertThat(query("SELECT * FROM " + tableName + " WHERE year(part) IS NOT DISTINCT FROM 2006"))
.isFullyPushedDown()
.returnsEmptyResult();

assertUpdate("DROP TABLE " + tableName);
}

Expand Down
4 changes: 4 additions & 0 deletions plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3321,6 +3321,10 @@ else if (format == AVRO) {
// year()
assertThat(query("SELECT * FROM test_year_transform_timestamptz WHERE year(d) = 2015"))
.isFullyPushedDown();
assertThat(query("SELECT * FROM test_year_transform_timestamptz WHERE year(d) IS DISTINCT FROM 2015"))
.isNotFullyPushedDown(FilterNode.class);
assertThat(query("SELECT * FROM test_year_transform_timestamptz WHERE year(d) IS NOT DISTINCT FROM 2015"))
.isFullyPushedDown();

// date_trunc
assertThat(query("SELECT * FROM test_year_transform_timestamptz WHERE date_trunc('year', d) = TIMESTAMP '2015-01-01 00:00:00.000000 UTC'"))
Expand Down