Skip to content

Add regression test for IS NOT DISTINCT FROM pushdown correctness #27242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2025
Merged

Add regression test for IS NOT DISTINCT FROM pushdown correctness #27242

merged 2 commits into from
Nov 10, 2025
+11 −0

Conversation

@hqbhoho
Copy link
Contributor

@hqbhoho hqbhoho commented Nov 7, 2025 •
edited by findepi
Loading

Description

Add regression test for IS NOT DISTINCT FROM pushdown in Iceberg/Delta Lake

@cla-bot cla-bot bot added the cla-signed label Nov 7, 2025
@github-actions github-actions bot added the iceberg Iceberg connector label Nov 7, 2025
@hqbhoho hqbhoho force-pushed the feature/test_pushdown branch from 0d653ec to 2688cc9 Compare November 7, 2025 09:24
@hqbhoho hqbhoho changed the title [NOT MERGE] Test pushdown [NOT MERGE] Test IS NOT DISTICNT FROM pushdown Nov 7, 2025
@hqbhoho hqbhoho force-pushed the feature/test_pushdown branch from 2688cc9 to 1cebc12 Compare November 7, 2025 10:03
@hqbhoho hqbhoho requested a review from findepi November 7, 2025 10:51
@hqbhoho hqbhoho mentioned this pull request Nov 7, 2025
Merged
@hqbhoho hqbhoho marked this pull request as draft November 7, 2025 11:14
@findepi findepi changed the title [NOT MERGE] Test IS NOT DISTICNT FROM pushdown Add regression test for IS DISTINCT FROM pushdown correctness Nov 7, 2025
@findepi
Copy link
Member

findepi commented Nov 7, 2025

@hqbhoho thank you for standing me corrected on the nature of the bug fixed in #27213.
we definitely should merge the regression test. Please revert the temporary changes from the PR so it's mergeable

@hqbhoho hqbhoho changed the title Add regression test for IS DISTINCT FROM pushdown correctness Add regression test for IS NOT DISTINCT FROM pushdown correctness Nov 8, 2025
@hqbhoho hqbhoho force-pushed the feature/test_pushdown branch from 1cebc12 to ce24b61 Compare November 8, 2025 11:13
@github-actions github-actions bot added the delta-lake Delta Lake connector label Nov 8, 2025
@hqbhoho hqbhoho marked this pull request as ready for review November 8, 2025 11:22
@hqbhoho hqbhoho requested a review from findepi November 8, 2025 11:22
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Nov 10, 2025
@findepi findepi merged commit 521f1aa into trinodb:master Nov 10, 2025
46 checks passed
@github-actions github-actions bot added this to the 479 milestone Nov 10, 2025
@chenjian2664 chenjian2664 mentioned this pull request Nov 11, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@findepi findepi findepi approved these changes

+1 more reviewer

@chenjian2664 chenjian2664 chenjian2664 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed delta-lake Delta Lake connector iceberg Iceberg connector no-release-notes This pull request does not require release notes entry

Milestone

479

Development

Successfully merging this pull request may close these issues.

3 participants

@hqbhoho @findepi @chenjian2664