Add build-success marker job to ci.yml

.github/workflows/ci.yml

@@ -50,6 +50,39 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  build-success:
+    if: ${{ always() }} # if `failure()` would not work for cancellations, `!success()` would not work for skipped jobs
+    runs-on: ubuntu-latest
+    needs:
+      - artifact-checks
+      - build-pt
+      - build-test-matrix
+      - check-commit
+      - check-commits-dispatcher
+      - error-prone-checks
+      - hive-tests
+      - maven-checks
+      - pt
+      - test
+      - test-jdbc-compatibility
+      - test-other-modules
+    steps:
+      - name: "Check results"
+        run: |
+          # generated by TestCiWorkflow
+          echo '${{ needs.artifact-checks.result }}' | grep -xE 'success|skipped' || { echo 'Job "artifact-checks" failed' >&2; exit 1; }
+          echo '${{ needs.build-pt.result }}' | grep -xE 'success|skipped' || { echo 'Job "build-pt" failed' >&2; exit 1; }
+          echo '${{ needs.build-test-matrix.result }}' | grep -xE 'success|skipped' || { echo 'Job "build-test-matrix" failed' >&2; exit 1; }
+          echo '${{ needs.check-commit.result }}' | grep -xE 'success|skipped' || { echo 'Job "check-commit" failed' >&2; exit 1; }
+          echo '${{ needs.check-commits-dispatcher.result }}' | grep -xE 'success|skipped' || { echo 'Job "check-commits-dispatcher" failed' >&2; exit 1; }
+          echo '${{ needs.error-prone-checks.result }}' | grep -xE 'success|skipped' || { echo 'Job "error-prone-checks" failed' >&2; exit 1; }
+          echo '${{ needs.hive-tests.result }}' | grep -xE 'success|skipped' || { echo 'Job "hive-tests" failed' >&2; exit 1; }
+          echo '${{ needs.maven-checks.result }}' | grep -xE 'success|skipped' || { echo 'Job "maven-checks" failed' >&2; exit 1; }
+          echo '${{ needs.pt.result }}' | grep -xE 'success|skipped' || { echo 'Job "pt" failed' >&2; exit 1; }
+          echo '${{ needs.test.result }}' | grep -xE 'success|skipped' || { echo 'Job "test" failed' >&2; exit 1; }
+          echo '${{ needs.test-jdbc-compatibility.result }}' | grep -xE 'success|skipped' || { echo 'Job "test-jdbc-compatibility" failed' >&2; exit 1; }
+          echo '${{ needs.test-other-modules.result }}' | grep -xE 'success|skipped' || { echo 'Job "test-other-modules" failed' >&2; exit 1; }
+
   maven-checks:
     runs-on: ubuntu-latest
     name: maven-checks ${{ matrix.java-version }}

testing/trino-tests/src/test/java/io/trino/tests/ci/TestCiWorkflow.java

@@ -35,6 +35,7 @@
 import static com.google.common.collect.ImmutableSet.toImmutableSet;
 import static com.google.common.collect.MoreCollectors.onlyElement;
 import static java.util.Locale.ENGLISH;
+import static java.util.function.Predicate.not;
 import static org.assertj.core.api.Assertions.assertThat;
 
 public class TestCiWorkflow
@@ -96,6 +97,46 @@ public void testUploadTestResultsCondition()
                 .containsExactlyInAnyOrderElementsOf(testStepIds);
     }
 
+    @Test
+    public void testBuildSuccessDependencies()
+            throws Exception
+    {
+        String buildSuccessJobName = "build-success";
+
+        Yaml yaml = new Yaml();
+        Map<?, ?> workflow = yaml.load(new StringReader(Files.readString(findRepositoryRoot().resolve(CI_YML_REPO_PATH))));
+        Map<String, ?> jobs = getMap(workflow, "jobs");
+
+        Set<String> allJobNames = jobs.keySet();
+        assertThat(allJobNames).as("allJobNames").contains(buildSuccessJobName);
+        List<String> testJobNames = allJobNames.stream()
+                .filter(not(buildSuccessJobName::equals))
+                .sorted()
+                .toList();
+        Map<?, ?> buildSuccessJob = getMap(jobs, buildSuccessJobName);
+
+        List<String> buildSuccessDependencies = getList(buildSuccessJob, "needs").stream()
+                .map(String.class::cast)
+                .toList();
+        assertThat(buildSuccessDependencies).as("dependencies for %s", buildSuccessJobName)
+                .isSorted()
+                .doesNotHaveDuplicates()
+                .containsExactlyElementsOf(testJobNames);
+
+        StringBuilder expectedRunDefinition = new StringBuilder();
+        expectedRunDefinition.append("# generated by %s\n".formatted(getClass().getSimpleName()));
+        for (String name : testJobNames) {
+            expectedRunDefinition.append(
+                    "echo '${{ needs.%1$s.result }}' | grep -xE 'success|skipped' || { echo 'Job \"%1$s\" failed' >&2; exit 1; }\n".formatted(name));
+        }
+        Map<?, ?> runDefinition = getList(buildSuccessJob, "steps").stream()
+                .map(step -> (Map<?, ?>) step)
+                .filter(step -> "Check results".equals(step.get("name")))
+                .collect(onlyElement());
+        assertThat(runDefinition.get("run")).as("run script")
+                .isEqualTo(expectedRunDefinition.toString());
+    }
+
     private static Path findRepositoryRoot()
     {
         Path workingDirectory = Paths.get("").toAbsolutePath();