-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add build-success marker job to ci.yml #27036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build-success marker job to ci.yml #27036
Conversation
Reviewer's GuideThis PR adds a new build-success sentinel job to the main GitHub Actions CI workflow that always runs after all other jobs, checks each preceding job’s result, and includes a unit test in TestCiWorkflow to verify its dependencies and script configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
testing/trino-tests/src/test/java/io/trino/tests/ci/TestCiWorkflow.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/ci/TestCiWorkflow.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/ci/TestCiWorkflow.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/ci/TestCiWorkflow.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a build-success marker job to the CI workflow that aggregates the results of all other jobs, ensuring the overall pipeline status accurately reflects individual job failures or cancellations. This provides a single, reliable status indicator for branch protection rules or other automation that depends on CI completion.
Key Changes:
- Introduces a
build-successjob that depends on all other CI jobs and validates their results - Adds test coverage to verify the job's dependencies match all other jobs and validates the generated run script
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds the build-success job with dependencies on all CI jobs and result validation logic |
testing/trino-tests/src/test/java/io/trino/tests/ci/TestCiWorkflow.java |
Adds test to verify build-success job dependencies and generated script match expectations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
testing/trino-tests/src/test/java/io/trino/tests/ci/TestCiWorkflow.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/ci/TestCiWorkflow.java
Outdated
Show resolved
Hide resolved
Add a new `build-success` job in the main CI GitHub Actions workflow. This job should pass when the whole workflow passes and should fail otherwise.
508e2de to
61cebef
Compare
|
@findepi roll dice harder ;-) |

Add a new
build-successjob in the main CI GitHub Actions workflow. This job should pass when the whole workflow passes and should fail otherwise.Summary by Sourcery
Add a build-success marker job to the main CI workflow to ensure the overall pipeline status reflects failures of any individual job, and update tests to verify its configuration
New Features:
CI:
Tests: