-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Disable TestIcebergS3TablesConnectorSmokeTest.testSelectInformationSchemaTables
#26958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ebyhr
merged 1 commit into
trinodb:master
from
chenjian2664:disable_flaky_s3_information_schema_tables
Oct 15, 2025
Merged
Disable TestIcebergS3TablesConnectorSmokeTest.testSelectInformationSchemaTables
#26958
ebyhr
merged 1 commit into
trinodb:master
from
chenjian2664:disable_flaky_s3_information_schema_tables
Oct 15, 2025
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR disables the unsupported Information Schema tables test in the S3 Tables connector smoke tests by annotating the overridden test method with @disabled. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3TablesConnectorSmokeTest.java:297-300` </location>
<code_context>
@Test
@Override // The procedure is unsupported in S3 Tables
public void testUnregisterTableAccessControl() {}
+
+ @Test
+ @Override
+ @Disabled
+ public void testSelectInformationSchemaTables() {}
}
</code_context>
<issue_to_address>
**suggestion (testing):** The test 'testSelectInformationSchemaTables' is disabled without an explanation.
Add a comment or annotation specifying the reason for disabling this test to provide context for future maintainers.
```suggestion
@Test
@Override
@Disabled("Unsupported in S3 Tables")
public void testSelectInformationSchemaTables() {}
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ebyhr
reviewed
Oct 15, 2025
...rc/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3TablesConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
45612e6 to
d004a2d
Compare
TestIcebergS3TablesConnectorSmokeTest.testSelectInformationSchemaTables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
#25129
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
Summary by Sourcery
Tests: