Skip to content

Conversation

@chenjian2664
Copy link
Contributor

@chenjian2664 chenjian2664 commented Oct 15, 2025

Description

Additional context and related issues

#25129

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Tests:

  • Annotate TestIcebergS3TablesConnectorSmokeTest.testSelectInformationSchemaTables with @disabled to skip it

@cla-bot cla-bot bot added the cla-signed label Oct 15, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 15, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR disables the unsupported Information Schema tables test in the S3 Tables connector smoke tests by annotating the overridden test method with @disabled.

File-Level Changes

Change Details Files
Disable unsupported Information Schema tables test in S3 Tables connector smoke tests
  • Annotated testSelectInformationSchemaTables() with @disabled
  • Kept @test and @OverRide annotations on the disabled method
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3TablesConnectorSmokeTest.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the iceberg Iceberg connector label Oct 15, 2025
@chenjian2664 chenjian2664 changed the title Disable `TestIcebergS3TablesConnectorSmokeTest.testSelectInformationS… Disable `TestIcebergS3TablesConnectorSmokeTest.testSelectInformationSchemaTables Oct 15, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3TablesConnectorSmokeTest.java:297-300` </location>
<code_context>
     @Test
     @Override // The procedure is unsupported in S3 Tables
     public void testUnregisterTableAccessControl() {}
+
+    @Test
+    @Override
+    @Disabled
+    public void testSelectInformationSchemaTables() {}
 }
</code_context>

<issue_to_address>
**suggestion (testing):** The test 'testSelectInformationSchemaTables' is disabled without an explanation.

Add a comment or annotation specifying the reason for disabling this test to provide context for future maintainers.

```suggestion
    @Test
    @Override
    @Disabled("Unsupported in S3 Tables")
    public void testSelectInformationSchemaTables() {}
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ebyhr ebyhr force-pushed the disable_flaky_s3_information_schema_tables branch from 45612e6 to d004a2d Compare October 15, 2025 00:45
@ebyhr ebyhr changed the title Disable `TestIcebergS3TablesConnectorSmokeTest.testSelectInformationSchemaTables Disable TestIcebergS3TablesConnectorSmokeTest.testSelectInformationSchemaTables Oct 15, 2025
@ebyhr ebyhr merged commit 5da5879 into trinodb:master Oct 15, 2025
10 of 22 checks passed
@github-actions github-actions bot added this to the 478 milestone Oct 15, 2025
@chenjian2664 chenjian2664 deleted the disable_flaky_s3_information_schema_tables branch October 15, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed iceberg Iceberg connector

Development

Successfully merging this pull request may close these issues.

2 participants