Skip to content

Harden pre-signed URI tests #26894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2025
Merged

Harden pre-signed URI tests #26894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fa9950
Generate second presigned uri for testing expiration
wendigo Oct 9, 2025
c93b5be
Retry presigned URI retrieval to retry on network issues
wendigo Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions lib/trino-filesystem/src/test/java/io/trino/filesystem/AbstractTestTrinoFileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,19 +1047,24 @@ public void testPreSignedUris()
}

Optional<UriLocation> directLocation = getFileSystem()
.preSignedUri(location, new Duration(3, SECONDS));
.preSignedUri(location, new Duration(30, SECONDS));

Optional<UriLocation> expiredDirectLocation = getFileSystem()
.preSignedUri(location, new Duration(1, SECONDS));

assertThat(directLocation).isPresent();
assertThat(retrieveUri(directLocation.get()))
.isEqualTo(TEST_BLOB_CONTENT_PREFIX + location);

assertEventually(new Duration(5, SECONDS), () -> assertThat(retrieveUri(directLocation.get()))
.isEqualTo(TEST_BLOB_CONTENT_PREFIX + location));

// Check if it can be retrieved more than once
assertThat(retrieveUri(directLocation.get()))
.isEqualTo(TEST_BLOB_CONTENT_PREFIX + location);
assertEventually(new Duration(5, SECONDS), () -> assertThat(retrieveUri(directLocation.get()))
.isEqualTo(TEST_BLOB_CONTENT_PREFIX + location));

// Check if after a timeout the pre-signed URI is no longer valid
assertEventually(new Duration(5, SECONDS), new Duration(1, SECONDS), () -> assertThatThrownBy(() -> retrieveUri(directLocation.get()))
.isInstanceOf(IOException.class));
assertEventually(new Duration(5, SECONDS), new Duration(1, SECONDS), () -> assertThatThrownBy(() -> retrieveUri(expiredDirectLocation.get()))
.isInstanceOf(IOException.class)
.hasMessageContaining("Failed to retrieve"));
}
}

Expand Down