Harden pre-signed URI tests

[wendigo]

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Harden pre-signed URI tests by extending valid duration, introducing an expired URI scenario, and using eventual assertions to account for retrieval delays.

Tests:

• Increase pre-signed URI validity from 3 to 30 seconds and generate a separate 1-second URI to test expiration
• Replace direct retrieval assertions with assertEventually calls to handle potential delays
• Assert that expired URIs throw an IOException containing "Failed to retrieve"

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Strengthened the pre-signed URI test by adjusting timeouts, introducing a short-lived URI for expiration verification, and wrapping retrieval checks in assertEventually to account for timing variances.

File-Level Changes

Change	Details	Files
Extended and segregated URI lifespans for robust expiration testing	Increased successful URI validity duration from 3 to 30 seconds Added a separate 1-second-duration URI (expiredDirectLocation) for expiration assertions	lib/trino-filesystem/src/test/java/io/trino/filesystem/AbstractTestTrinoFileSystem.java
Replaced direct retrieval assertions with assertEventually to handle eventual consistency	Wrapped initial retrieveUri assertion in assertEventually with a 5-second timeout Applied assertEventually for the repeated retrieval check to ensure stability	lib/trino-filesystem/src/test/java/io/trino/filesystem/AbstractTestTrinoFileSystem.java
Improved expiration failure check with explicit exception validation	Switched expiration test to use the 1-second URI (expiredDirectLocation) Used assertThatThrownBy to verify IOException and match message containing “Failed to retrieve”	lib/trino-filesystem/src/test/java/io/trino/filesystem/AbstractTestTrinoFileSystem.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}