Detect and close I/O leaks in the native FS implementations #26087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
approved these changes
Jun 27, 2025
wendigo
force-pushed
the
serafin/fs-leak-detector
branch
3 times, most recently
from
d6a8685 to
d310a30
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds I/O stream leak detection functionality to the native filesystem. Key changes include the introduction of several LeakDetecting* wrapper classes to monitor resource usage, updates to the filesystem factory and module for conditional activation, and corresponding configuration and tests updates.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/trino-filesystem/src/main/java/io/trino/filesystem/leakdetection/TrackedLocationState.java | Added state tracking with stack trace capture for leak detection. |
| lib/trino-filesystem/src/main/java/io/trino/filesystem/leakdetection/LeakDetecting*.java | Introduced output and input stream/file wrappers incorporating leak detection. |
| lib/trino-filesystem-manager/src/test/java/io/trino/filesystem/manager/TestFileSystemConfig.java | Updated tests to verify the new leak detection configuration. |
| lib/trino-filesystem-manager/src/main/java/io/trino/filesystem/manager/FileSystemModule.java | Integrated leak detection based on configuration and CI environment variable. |
| lib/trino-filesystem-manager/src/main/java/io/trino/filesystem/manager/FileSystemConfig.java | Added new configuration property to enable/disable leak detection. |
Comments suppressed due to low confidence (1)
lib/trino-filesystem-manager/src/main/java/io/trino/filesystem/manager/FileSystemModule.java:169
- [nitpick] Consider adding a comment explaining why the 'CONTINUOUS_INTEGRATION' environment variable is used to activate leak detection, so future maintainers understand this design decision.
boolean leakDetectionEnabled = getenv("CONTINUOUS_INTEGRATION") != null;
lib/trino-filesystem/src/main/java/io/trino/filesystem/leakdetection/TrackedLocationState.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/fs-leak-detector
branch
from
d310a30 to
ad2e69c
Compare
wendigo
changed the title
anusudarsan
approved these changes
Jun 27, 2025
wendigo
force-pushed
the
serafin/fs-leak-detector
branch
from
ad2e69c to
65e8eb5
Compare
It is enable by default in the CI to report detected leaks
wendigo
force-pushed
the
serafin/fs-leak-detector
branch
from
65e8eb5 to
6dfa435
Compare
electrum
reviewed
Jun 27, 2025
| delegate = new TracingFileSystemFactory(tracer, delegate); | ||
|
|
||
| // Enable leak detection if configured or if running in a CI environment | ||
| boolean trackingDetectionEnabled = getenv("CONTINUOUS_INTEGRATION") != null; |
Member
There was a problem hiding this comment.
You can make this the default for the config, allowing it to be overridden in either case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's enabled by default in the CI
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: