-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Use self-hosted Roboto font in the UI #26053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why was the pr before this supersede? |
|
@nadavtzaysler it's a simpler implementation |
|
@wendigo It's a simple change in the css file, could've been made in the same pr Also woof2 files are considered better to use in web apps so i believe the implementation before is more ideal |
d3867fb to
69dd2c5
Compare
69dd2c5 to
264c850
Compare
|
@nadavtzaysler this PR isn't a copy, I've made it from scratch addressing the linked issue |
264c850 to
2012a9f
Compare
|
I dont mind which PR is merged - whichever is better. I think we should just add a co authored by line in the commit message so the changes are attributed to both @nadavtzaysler and @wendigo |
|
Since CLA is not signed I can't add authorship and as said these are two separate PRs addressing the same issue with two different and distinct implementations @mosabua |
Fixes #26031
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: