-
Notifications
You must be signed in to change notification settings - Fork 3.4k
changes html to get fonts from local css file #26030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes html to get fonts from local css file #26030
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
mosabua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to send a separate PR for the preview UI or is it all sorted out there already?
core/trino-web-ui/src/main/resources/webapp/oauth2/failure.html
Outdated
Show resolved
Hide resolved
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
|
How does the current approach actually help? You are still not locally embedding the font files .. you are just using a CSS file now to point to them? |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thanks for actually adding the fonts.. before you just changed to a different URL from which to load the files and lead them from a separate CSS file .. now the files are actually local. Please rebase and test this with different browsers and check on the browser console that no other fonts are requested |
|
Also squash commits and update the commit message to |
|
Superseded by #26053 |
|
Why was this pr superseded? |
|
@mosabua Can this pr be reopened, the pr that was supposed to supersede it doesn't seem more ideal and it's stale while this could've been merged |
Description
added css file to fetch all used fonts from fixed path in app
changed dockerfile to take all used fonts from fonts.gstatic and load them into app
changed html to get css from file instead of google API
Fixes #26031
Additional context and related issues
Release notes
( X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: