Skip to content

Support read 'p' type deletion vectors in Delta Lake#24946

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
chenjian2664:delta_p_dv
Feb 7, 2025
Merged

Support read 'p' type deletion vectors in Delta Lake#24946
ebyhr merged 1 commit intotrinodb:masterfrom
chenjian2664:delta_p_dv

Conversation

@chenjian2664
Copy link
Copy Markdown
Contributor

@chenjian2664 chenjian2664 commented Feb 7, 2025

Description

This is also a prerequirements for testing MERGE behavior with deletion vectors proposed in #24756

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Delta Lake
* Support read 'p' type deletion vectors in Delta Lake. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 7, 2025
@chenjian2664 chenjian2664 requested a review from ebyhr February 7, 2025 03:43
@github-actions github-actions bot added the delta-lake Delta Lake connector label Feb 7, 2025
@chenjian2664 chenjian2664 requested a review from pajaks February 7, 2025 03:43
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Feb 7, 2025

storageType = 'p' means an absolute path. https://github.com/delta-io/delta/blob/master/PROTOCOL.md#deletion-vector-descriptor-schema. A static resource-based test may not be suitable.

@chenjian2664 chenjian2664 force-pushed the delta_p_dv branch 2 times, most recently from 7614584 to e586019 Compare February 7, 2025 06:44
Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for comments.

@chenjian2664 chenjian2664 force-pushed the delta_p_dv branch 4 times, most recently from 1056a0e to e887fbe Compare February 7, 2025 11:31
@chenjian2664 chenjian2664 requested a review from ebyhr February 7, 2025 13:38
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Feb 7, 2025

/test-with-secrets sha=075752b92f04ede70f881651230a2d1b3e3f9817

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2025

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/13208944897

@ebyhr ebyhr merged commit ec8a019 into trinodb:master Feb 7, 2025
@github-actions github-actions bot added this to the 471 milestone Feb 7, 2025
@chenjian2664 chenjian2664 deleted the delta_p_dv branch February 18, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed delta-lake Delta Lake connector

Development

Successfully merging this pull request may close these issues.

2 participants