Support MERGE on cloned table in Delta Lake#24756
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Mar 21, 2025
Merged
Conversation
37ff93a to
60e9e73
Compare
60e9e73 to
6432fab
Compare
9bc68fc to
0cb664f
Compare
pajaks
reviewed
Jan 24, 2025
7ef5f5d to
be52ef7
Compare
be52ef7 to
1b33203
Compare
pajaks
reviewed
Feb 3, 2025
b583ce9 to
e8d8d33
Compare
e8d8d33 to
c76bcf1
Compare
pajaks
reviewed
Feb 5, 2025
c76bcf1 to
5325f92
Compare
pajaks
reviewed
Feb 6, 2025
5325f92 to
93cbd29
Compare
pajaks
reviewed
Feb 10, 2025
93cbd29 to
2aef993
Compare
Contributor
Author
pajaks
approved these changes
Feb 11, 2025
2577e5d to
0b2cb43
Compare
Member
|
/test-with-secrets sha=0b2cb43ae47dea47a9f7fb86d745453699188cb3 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/13281480006 |
ebyhr
reviewed
Feb 18, 2025
0b2cb43 to
3a91f70
Compare
Member
|
@chenjian2664 Please throw exceptions for unclear situations. This is initial merge support for cloned tables. We should start as strict as possible. |
463ab8e to
0f5aa9c
Compare
0f5aa9c to
f16e93c
Compare
Member
|
(Rebased on master with no changes) |
ebyhr
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix problem that fail update on cloned table, reproduce steps:
testing/bin/ptl env up --environment singlenode-delta-lake-ossIn Trino:
create schema delta.tiny with (location='s3://test-bucket/tiny/');In Spark-sql:
CREATE TABLE tiny.t1 (id int, v string, part date) USING DELTA PARTITIONED BY (part);In Trino:
insert into delta.tiny.t1 values (1, 'A', TIMESTAMP '2024-01-01'), (2, 'B', TIMESTAMP '2024-01-01'), (3, 'C', TIMESTAMP '2024-02-02'), (4, 'D', TIMESTAMP '2024-02-02');In Spark-sql:
CREATE TABLE tiny.t1clone SHALLOW CLONE tiny.t1;In Trino:
update delta.tiny.t1clone set v = 'update1' where id in (1,3);It fails with:Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: