Support Clickhouse varchar comparison pushdown#23558
Merged
Praveen2112 merged 2 commits intotrinodb:masterfrom Sep 26, 2024
Merged
Conversation
This was referenced Sep 25, 2024
42ab5c4 to
6cdf3fc
Compare
Praveen2112
reviewed
Sep 25, 2024
Comment on lines
949
to
959
Member
There was a problem hiding this comment.
Can we move this to a dedicated test for enums ?
Contributor
Author
There was a problem hiding this comment.
It was initially implemented as a dedicated test, however it is duplicated in this test anyway to support:
assertThat(query("SELECT some_column FROM " + table.getName() + " WHERE a_string = a_string_alias")).isFullyPushedDown();
assertThat(query("SELECT some_column FROM " + table.getName() + " WHERE a_string = a_string_alias" + withConnectorExpression)).isFullyPushedDown();
assertThat(query("SELECT some_column FROM " + table.getName() + " WHERE a_string = a_enum_1")).isNotFullyPushedDown(FilterNode.class);
assertThat(query("SELECT some_column FROM " + table.getName() + " WHERE a_string = a_enum_1" + withConnectorExpression)).isNotFullyPushedDown(FilterNode.class);
scenarios. So let it be as it is.
...-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteStringComparison.java
Outdated
Show resolved
Hide resolved
6cdf3fc to
15585ed
Compare
Contributor
Author
|
@Praveen2112 please approve |
Praveen2112
approved these changes
Sep 25, 2024
Member
Praveen2112
left a comment
There was a problem hiding this comment.
LGTM % changes on method name and additional test coverage for a few data types.
...-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteStringComparison.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
ffd6822 to
d774d3a
Compare
Contributor
Author
|
@Praveen2112 all comments are addressed. |
Praveen2112
approved these changes
Sep 25, 2024
Member
Praveen2112
left a comment
There was a problem hiding this comment.
Thanks for working on this.
Member
6498658 to
3d8a123
Compare
ebyhr
approved these changes
Sep 26, 2024
3d8a123 to
fa2459a
Compare
This was referenced Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: