Improve Clickhouse varchar equalities pushdown#23455
Closed
ssheikin wants to merge 2 commits intotrinodb:masterfrom
Closed
Improve Clickhouse varchar equalities pushdown#23455ssheikin wants to merge 2 commits intotrinodb:masterfrom
ssheikin wants to merge 2 commits intotrinodb:masterfrom
Conversation
Praveen2112
reviewed
Sep 17, 2024
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
Outdated
Show resolved
Hide resolved
ssheikin
force-pushed
the
ssheikin/55/trino/clickhouse-pushdown-predicate-equalities
branch
3 times, most recently
from
2870fa9 to
660766a
Compare
Contributor
Author
|
@Praveen2112 please approve. |
wendigo
reviewed
Sep 17, 2024
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/expression/RewriteIn.java
Outdated
Show resolved
Hide resolved
ssheikin
force-pushed
the
ssheikin/55/trino/clickhouse-pushdown-predicate-equalities
branch
from
660766a to
8ebe081
Compare
Contributor
Author
|
All comments are addressed. Please approve. |
ssheikin
force-pushed
the
ssheikin/55/trino/clickhouse-pushdown-predicate-equalities
branch
from
8ebe081 to
6715345
Compare
hashhar
requested changes
Sep 17, 2024
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
I need to verify if tests are using connector expression pushdown or tuple domain.
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
Member
|
also I see clickhouse connector can both expose So do we need to test in both modes the pushdown? Does it matter? |
Member
I guess for simple expression we use TupleDomain and for expression with OR it would use connector expression |
ssheikin
force-pushed
the
ssheikin/55/trino/clickhouse-pushdown-predicate-equalities
branch
from
6715345 to
99b9636
Compare
ssheikin
commented
Sep 18, 2024
Contributor
Author
There was a problem hiding this comment.
also I see clickhouse connector can both expose
FixedString/Stringas TrinoVARCHARandVARBINARY(default).So do we need to test in both modes the pushdown? Does it matter?
@hashhar @Praveen2112 considering
// TODO (#7102) reconsider default behavior
Support for VARBINARY may be considered as a separate effort.
ssheikin
force-pushed
the
ssheikin/55/trino/clickhouse-pushdown-predicate-equalities
branch
from
99b9636 to
7cd3dbb
Compare
Contributor
Author
|
@hashhar @Praveen2112 All comments addressed. Please approve. |
ssheikin
force-pushed
the
ssheikin/55/trino/clickhouse-pushdown-predicate-equalities
branch
from
7cd3dbb to
dc5a204
Compare
ssheikin
requested review from
Praveen2112,
ebyhr,
hashhar,
raunaqmorarka,
sylph-eu and
wendigo
Predicate pushdown - equals - in - like - is null - null if
ssheikin
force-pushed
the
ssheikin/55/trino/clickhouse-pushdown-predicate-equalities
branch
from
dc5a204 to
f1a8cf4
Compare
Contributor
Author
|
Closing as it has partially transformed to #23558 |
This was referenced Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connector expressions
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: