You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I was wondering if we should give some concrete use cases of one or the other but I think it's not that easy to give a "definitive" information. Some might use the fat JAR in a context where someone else might prefer the non shaded one.
JDBC driver used in some BI/IDE tool which usually don't have a maven resolver hence fat jar is used because it is standalone,
JDBC driver used in the application (as a Maven/Gradle/SBT dependency), in this case the user can choose between fat-jar and non-shaded artifact, the latter usually requires settling on the version bounds/resolving conflicts which could be a tricky since the Trino depends on the latest versions of the libraries we depend upon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See title and changes.
Additional context and related issues
Follow up to #22098
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.