Skip to content

Add docs for non-shaded JDBC driver JAR#23254

Merged
mosabua merged 1 commit intotrinodb:masterfrom
simpligility:jdbc
Sep 4, 2024
Merged

Add docs for non-shaded JDBC driver JAR#23254
mosabua merged 1 commit intotrinodb:masterfrom
simpligility:jdbc

Conversation

@mosabua
Copy link
Copy Markdown
Member

@mosabua mosabua commented Sep 3, 2024

Description

See title and changes.

Additional context and related issues

Follow up to #22098

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Sep 3, 2024
@github-actions github-actions bot added the docs label Sep 3, 2024
@mosabua mosabua requested review from gaeljw and wendigo September 3, 2024 19:40
Comment thread docs/src/main/sphinx/client/jdbc.md Outdated
Copy link
Copy Markdown

@gaeljw gaeljw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was wondering if we should give some concrete use cases of one or the other but I think it's not that easy to give a "definitive" information. Some might use the fat JAR in a context where someone else might prefer the non shaded one.

@wendigo
Copy link
Copy Markdown
Contributor

wendigo commented Sep 4, 2024

@gaeljw there are basically two use cases:

  • JDBC driver used in some BI/IDE tool which usually don't have a maven resolver hence fat jar is used because it is standalone,

  • JDBC driver used in the application (as a Maven/Gradle/SBT dependency), in this case the user can choose between fat-jar and non-shaded artifact, the latter usually requires settling on the version bounds/resolving conflicts which could be a tricky since the Trino depends on the latest versions of the libraries we depend upon

@mosabua mosabua merged commit e21e7d3 into trinodb:master Sep 4, 2024
@mosabua mosabua deleted the jdbc branch September 4, 2024 19:07
@github-actions github-actions bot added this to the 456 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants