Skip to content

Produce nonshaded trino-jdbc#22098

Merged
wendigo merged 2 commits intomasterfrom
serafin/add-non-shaded-jar
Aug 30, 2024
Merged

Produce nonshaded trino-jdbc#22098
wendigo merged 2 commits intomasterfrom
serafin/add-non-shaded-jar

Conversation

@wendigo
Copy link
Copy Markdown
Contributor

@wendigo wendigo commented May 23, 2024

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 23, 2024
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label May 23, 2024
@wendigo wendigo requested review from ebyhr and findepi May 24, 2024 07:30
Comment thread client/trino-jdbc/pom.xml Outdated
@wendigo wendigo force-pushed the serafin/add-non-shaded-jar branch from 0f1fdda to 7dbcde8 Compare May 25, 2024 11:26
@github-actions
Copy link
Copy Markdown

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jun 17, 2024
@ebyhr ebyhr removed their request for review June 25, 2024 01:45
@github-actions github-actions bot removed the stale label Jun 25, 2024
@github-actions
Copy link
Copy Markdown

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jul 17, 2024
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jul 17, 2024

Any issues with this @wendigo ? Do we need @electrum to look?

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jul 17, 2024

Also .. should we document this for any reason? And also I assume the default jar is shaded and we dont want to break users and change that.. although arguably the default one should be non-shaded..

@github-actions github-actions bot removed the stale label Jul 18, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 9, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Aug 9, 2024
@github-actions
Copy link
Copy Markdown

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Aug 30, 2024
@wendigo wendigo deleted the serafin/add-non-shaded-jar branch August 30, 2024 17:34
@wendigo wendigo restored the serafin/add-non-shaded-jar branch August 30, 2024 17:34
@wendigo wendigo reopened this Aug 30, 2024
Non-shaded version allows usage of classes like InMemoryTrinoResultSet which depend on the trino-client classes
which are shaded. This will cause a class mismatch in the runtime (non-shaded class vs shaded-one).
It's useful for testing when one would like to mock ResultSet.
@wendigo wendigo force-pushed the serafin/add-non-shaded-jar branch from 7dbcde8 to ade8d5c Compare August 30, 2024 17:36
@mosabua mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Aug 30, 2024
@gaeljw
Copy link
Copy Markdown

gaeljw commented Aug 30, 2024

Also .. should we document this for any reason?

I think this should absolutely be documented, maybe even with a word for users to know which dependency to use in which context and/or pros/cons of each dependency.

@wendigo wendigo merged commit 1a5728c into master Aug 30, 2024
@wendigo wendigo deleted the serafin/add-non-shaded-jar branch August 30, 2024 22:47
@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Aug 30, 2024

@mosabua we need to follow up documenting this

@github-actions github-actions bot added this to the 456 milestone Aug 30, 2024
@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Aug 30, 2024

@gaeljw we will! Thanks for the feedback and sorry for shipping this so late

@gaeljw
Copy link
Copy Markdown

gaeljw commented Aug 31, 2024

Thanks a lot folks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed jdbc Relates to Trino JDBC driver stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.

Development

Successfully merging this pull request may close these issues.

4 participants