Skip to content

Add StandardErrorCode.ILLEGAL_ENTITY_KIND #22929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 1 commit into from
Aug 5, 2024
Merged

Add StandardErrorCode.ILLEGAL_ENTITY_KIND #22929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/trino-spi/src/main/java/io/trino/spi/StandardErrorCode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ public enum StandardErrorCode
MISSING_PATH_NAME(128, USER_ERROR),
INVALID_PLAN(129, USER_ERROR),
INVALID_VIEW_PROPERTY(130, USER_ERROR),
INVALID_ENTITY_KIND(131, USER_ERROR),
Copy link
Copy Markdown
Member

@ebyhr ebyhr Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add StandardErrorCode.ILLEGAL_ENTITY_KIND

The commit message is wrong though it's too late.

Copy link
Copy Markdown
Member Author

@djsagain djsagain Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is wrong with the commit message?

Copy link
Copy Markdown
Member

@ebyhr ebyhr Aug 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit added INVALID_ENTITY_KIND, not ILLEGAL_ENTITY_KIND.

Copy link
Copy Markdown
Contributor

@wendigo wendigo Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message says "illegal" while the error code const says "invalid". I guess that what's Yuya meant

Copy link
Copy Markdown
Contributor

@wendigo wendigo Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice that and it's my fault


GENERIC_INTERNAL_ERROR(65536, INTERNAL_ERROR),
TOO_MANY_REQUESTS_FAILED(65537, INTERNAL_ERROR),
Expand Down