Add StandardErrorCode.ILLEGAL_ENTITY_KIND#22929
Merged
wendigo merged 1 commit intotrinodb:masterfrom Aug 5, 2024
Merged
Conversation
Now that Trino can grant/deny/revoke privileges on arbitrary entity kinds, we need a StandardErrorCode for unrecognized entity kinds.
wendigo
approved these changes
Aug 4, 2024
codyzwief
approved these changes
Aug 5, 2024
ebyhr
reviewed
Aug 5, 2024
| MISSING_PATH_NAME(128, USER_ERROR), | ||
| INVALID_PLAN(129, USER_ERROR), | ||
| INVALID_VIEW_PROPERTY(130, USER_ERROR), | ||
| INVALID_ENTITY_KIND(131, USER_ERROR), |
Member
There was a problem hiding this comment.
Add StandardErrorCode.ILLEGAL_ENTITY_KIND
The commit message is wrong though it's too late.
Member
Author
There was a problem hiding this comment.
What is wrong with the commit message?
Member
There was a problem hiding this comment.
The commit added INVALID_ENTITY_KIND, not ILLEGAL_ENTITY_KIND.
Contributor
There was a problem hiding this comment.
The commit message says "illegal" while the error code const says "invalid". I guess that what's Yuya meant
Contributor
There was a problem hiding this comment.
I didn't notice that and it's my fault
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Trino can grant/deny/revoke privileges on arbitrary entity kinds, we need a StandardErrorCode for unrecognized entity kinds.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: