Skip to content

Reduce repetitions of testCreateFileRetry #20144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 1 commit into from
Dec 17, 2023
Merged

Reduce repetitions of testCreateFileRetry #20144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/trino-filesystem-gcs/src/test/java/io/trino/filesystem/gcs/TestGcsFileSystemGcs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,12 @@ void setup()
@Test
void testCreateFileRetry()
{
// Note: this test is meant to expose flakiness
// Without retries it may fail non-deterministically.
// Retries are enabled in the default GcsFileSystemConfig.
// In practice this may happen between 7 and 20 retries.
assertThatNoException().isThrownBy(() -> {
for (int i = 1; i <= 100; i++) {
for (int i = 1; i <= 30; i++) {
TrinoOutputFile outputFile = getFileSystem().newOutputFile(getRootLocation().appendPath("testFile"));
try (OutputStream out = outputFile.createOrOverwrite()) {
out.write("test".getBytes(UTF_8));
Expand Down