Reduce repetitions of testCreateFileRetry#20144
Merged
wendigo merged 1 commit intotrinodb:masterfrom Dec 17, 2023
Merged
Conversation
elonazoulay
force-pushed
the
gcs_follow_up1
branch
from
796fdf5 to
7b55526
Compare
Member
Author
|
Follow up to address suggestions in #20003 |
Member
Author
|
The only test that failed is |
wendigo
approved these changes
Dec 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce the time from about 120-130s to 35-37s by reducing the repetitions from 100 -> 30.
Also added a comment explaining the reason for the testCreateFileRetry test.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: